add-k8s incorrectly reports "cloud already exists"

[Cory Johns]

Steps to reproduce:

$ juju add-k8s kubernetes
$ juju remove-cloud kubernetes
Removed details of personal cloud "kubernetes"
$ juju show-cloud kubernetes
ERROR cloud "kubernetes" not found
$ juju add-k8s kubernetes
ERROR cloud "kubernetes" already exists (already exists)

Note that the cluster information is updated, but it is also updated if you don't remove-cloud first. Perhaps add-k8s should support an --overwrite option?

[John A Meinel (jameinel)]

It sounds more like we are leaving some bit of information behind that we
then treat incorrectly. We probably just need to be more careful around
'remove-cloud' really deleting it.

On Thu, May 3, 2018 at 3:31 PM, Cory Johns <email address hidden> wrote:

> Public bug reported:
>
> Steps to reproduce:
>
> $ juju add-k8s kubernetes
> $ juju remove-cloud kubernetes
> Removed details of personal cloud "kubernetes"
> $ juju show-cloud kubernetes
> ERROR cloud "kubernetes" not found
> $ juju add-k8s kubernetes
>
>
> ERROR cloud "kubernetes" already exists (already exists)
>
> Note that the cluster information is updated, but it is also updated if
> you don't remove-cloud first. Perhaps add-k8s should support an
> --overwrite option?
>
> ** Affects: juju
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1768845
>
> Title:
> add-k8s incorrectly reports "cloud already exists"
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1768845/+subscriptions
>

[Christopher Lee (veebers)]

This is related to LP:1768847 where the command "add-k8s" populates data on the controller. remove-cloud isn't hitting the controller to get the DB cleaned up.

I'm hoping for clarification on the experience expectation of "add-k8s" which will guide the fix for this bug.

Possible outcome might be:
  - remove-cloud, if removing a kubernetes cloud type, hits all the controllers and removes from the db.

[Christopher Lee (veebers)]

The "add-k8s" command stores data on the active controller as well as local config.
"remove-cloud" needs to check the controller, if the cloud is in use refuse to remove and if not in use remove the details from the controller db. It then (potentially, see below) will remove the details from the local config.

Query:
What if someone has "add-k8s blah" on multi controllers? Thus having the details on many controllers, should the remove-cloud command:
  - attempt to contact all known controllers and attempt removal from them
  - Only remove from the active controller, and from the local config?

Should (and I know splitting commands is frowned upon) this be split, to:
  - remove-k8s -> remove details from controller (if not in use) leaving local config alone.
  - remove-cloud -> Only attempts to remove from local config
    - This might mean that "add-k8s" will fail if trying to re-run on a controller that hasn't had 'remove-k8s' on it
    - Perhaps need to add --overwrite or --replace to "add-k8s" that will re-populate the details on the controller side.

[Ian Booth (wallyworld)]

There's now a remove-k8s command which you can use to remove from the controller a k8s cluster/cloud previously added with add-k8s.