create-storage-pool unnecessarily requires key=value pairs

Bug #1765688 reported by Roger Peppe on 2018-04-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju
Medium
Anastasia
2.3
Medium
Anastasia

Bug Description

The create-storage-pool command implies in its usage information that the key-value attributes are optional:

    Usage: juju create-storage-pool [options] <name> <provider> [<key>=<value> [<key>=<value>...]]

However the command fails if you don't provide at least one key-value pair.
Given that some of the storage providers don't seem to have any keys defined (see for example the "gce" provider in https://jujucharms.com/docs/devel/charms-storage#storage-providers), requiring them seems unnecessary.

The usage information for create-storage-pool should probably also point to somewhere where the available providers and their attributes are defined (ideally in juju help, because the online docs might be for a different juju version than is being run on the command line).

Anastasia (anastasia-macmood) wrote :

I'll adjust the help text for the command as well the check.

However, we do not have a dedicated 'juju help' that describes providers better than what is on https://jujucharms.com/docs/devel/charms-storage#storage-providers. AFAIK, this is the point of truth in terms of documentation and we do make an effort to keep it current.

Changed in juju:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Anastasia (anastasia-macmood)
tags: added: usability
Anastasia (anastasia-macmood) wrote :

Cut-and-paste excitement... Of course, the point of truth is in 'stable' not 'devel' stream - https://jujucharms.com/docs/stable/charms-storage#storage-providers

Anastasia (anastasia-macmood) wrote :
Changed in juju:
milestone: none → 2.4-beta2
status: Triaged → In Progress
Changed in juju:
status: In Progress → Fix Committed
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers