intermittent failure in ExternalControllerUpdaterSuite.TestWatchExternalControllers

[Anastasia]

As per http://ci.jujucharms.com/job/github-check-merge-juju/866/console,

----------------------------------------------------------------------
FAIL: externalcontrollerupdater_test.go:95: ExternalControllerUpdaterSuite.TestWatchExternalControllers

[LOG] 0:00.000 DEBUG juju.worker.externalcontrollerupdater external controllers changed: ["deadbeef-1bad-500d-9000-4b1d0d06f00d"]
[LOG] 0:00.000 INFO juju.worker.externalcontrollerupdater starting watcher for external controller "deadbeef-1bad-500d-9000-4b1d0d06f00d"
[LOG] 0:00.000 DEBUG juju.worker start "deadbeef-1bad-500d-9000-4b1d0d06f00d"
[LOG] 0:00.000 INFO juju.worker start "deadbeef-1bad-500d-9000-4b1d0d06f00d"
[LOG] 0:00.000 DEBUG juju.worker "deadbeef-1bad-500d-9000-4b1d0d06f00d" started
[LOG] 0:00.000 DEBUG juju.worker.externalcontrollerupdater controller info for controller "deadbeef-1bad-500d-9000-4b1d0d06f00d": &{controller-deadbeef-1bad-500d-9000-4b1d0d06f00d foo [bar] baz}
[LOG] 0:00.000 INFO juju.worker.externalcontrollerupdater new controller info for controller "deadbeef-1bad-500d-9000-4b1d0d06f00d": &{controller-deadbeef-1bad-500d-9000-4b1d0d06f00d foo [foo] baz}
[LOG] 0:00.001 DEBUG juju.worker killing runner 0xc4200dd110
[LOG] 0:00.001 INFO juju.worker runner is dying
[LOG] 0:00.001 DEBUG juju.worker killing "deadbeef-1bad-500d-9000-4b1d0d06f00d"
[LOG] 0:00.001 INFO juju.worker stopped "deadbeef-1bad-500d-9000-4b1d0d06f00d", err: <nil>
[LOG] 0:00.001 DEBUG juju.worker "deadbeef-1bad-500d-9000-4b1d0d06f00d" done: <nil>
[LOG] 0:00.001 DEBUG juju.worker no restart, removing "deadbeef-1bad-500d-9000-4b1d0d06f00d" from known workers
externalcontrollerupdater_test.go:144:
    s.watcher.Stub.CheckCallNames(c,
        "WatchControllerInfo",
        "ControllerInfo",
        "Close",
        "WatchControllerInfo",
        "ControllerInfo", // no change
        "ControllerInfo", // no change
        "Close",
    )
/workspace/src/github.com/juju/testing/stub.go:248:
    return c.Check(funcNames, jc.DeepEquals, expected)
... obtained []string = []string{"WatchControllerInfo", "ControllerInfo", "Close", "WatchControllerInfo", "ControllerInfo", "Close"}
... expected []string = []string{"WatchControllerInfo", "ControllerInfo", "Close", "WatchControllerInfo", "ControllerInfo", "ControllerInfo", "Close"}
... mismatch at top level: length mismatch, 6 vs 7; obtained []string{"WatchControllerInfo", "ControllerInfo", "Close", "WatchControllerInfo", "ControllerInfo", "Close"}; expected []string{"WatchControllerInfo", "ControllerInfo", "Close", "WatchControllerInfo", "ControllerInfo", "ControllerInfo", "Close"}

OOPS: 6 passed, 1 FAILED
--- FAIL: TestPackage (1.02s)
FAIL
FAIL github.com/juju/juju/worker/externalcontrollerupdater 3.473s

[Anastasia (anastasia-macmood)]

Since the report was filed we have done great improvements in watchers area and have not seen re-occurrence of this failure. I am marking this as Fix Released.