cmd/juju/commands tests failing on Windows

[John A Meinel]

As seen here:

http://10.125.0.203:8080/job/RunUnittests-win2012/140/console

BootstrapSuite.TestBootstrapProviderFileCredential
and
HelpToolSuite.TestHelpToolHelp

Are both failing.

The former because it is using "gc.Matches" and doing a regex match against a path (which on Windows ends up as C:\Users..., which fails because \U is not a known regex escape).
And the latter because it is using one variable for finding the "longest string" and a different one for actually formatting. And it turns out on Windows the former is "foo.exe" while the latter is just "foo".

[John A Meinel (jameinel)]

https://github.com/juju/juju/pull/8426

[John A Meinel (jameinel)]

Note that in develop
github.com/juju/juju/cmd/juju/cloud
FAIL: updatecredential_test.go:112: updateCredentialSuite.TestUpdateCredentialWithFilePath

also fails because of gc.Matches vs gc.Equals.

However, this test does not appear in 2.3

[John A Meinel (jameinel)]

(it fails, but for a different reason. It fails because it tries to remove a file before closing it)

[John A Meinel (jameinel)]

https://github.com/juju/juju/pull/8428
merges the change into 2.4