cmd/juju/commands tests failing on Windows

Bug #1751774 reported by John A Meinel on 2018-02-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju
High
John A Meinel
2.3
High
John A Meinel

Bug Description

As seen here:

http://10.125.0.203:8080/job/RunUnittests-win2012/140/console

BootstrapSuite.TestBootstrapProviderFileCredential
and
HelpToolSuite.TestHelpToolHelp

Are both failing.

The former because it is using "gc.Matches" and doing a regex match against a path (which on Windows ends up as C:\Users..., which fails because \U is not a known regex escape).
And the latter because it is using one variable for finding the "longest string" and a different one for actually formatting. And it turns out on Windows the former is "foo.exe" while the latter is just "foo".

John A Meinel (jameinel) wrote :

Note that in develop
github.com/juju/juju/cmd/juju/cloud
FAIL: updatecredential_test.go:112: updateCredentialSuite.TestUpdateCredentialWithFilePath

also fails because of gc.Matches vs gc.Equals.

However, this test does not appear in 2.3

John A Meinel (jameinel) wrote :

(it fails, but for a different reason. It fails because it tries to remove a file before closing it)

John A Meinel (jameinel) wrote :

https://github.com/juju/juju/pull/8428
merges the change into 2.4

John A Meinel (jameinel) on 2018-02-27
Changed in juju:
status: In Progress → Fix Committed
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers