Canonical Juju

race in provisioner test suite

Bug #1749003 reported by Tim Penhey on 2018-02-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Canonical Juju	Fix Released	High	Witold Krecicki

Bug Description

        ==================
WARNING: DATA RACE
Read at 0x00c420c9c750 by goroutine 131:
  runtime.mapiterinit()
      /snap/go/1404/src/runtime/hashmap.go:709 +0x0
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateAvailabilityZoneMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:755 +0x28d
  github.com/juju/juju/worker/provisioner.NewProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:118 +0x6f2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTaskWithRetryStrategy()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1344 +0x462
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1323 +0xe2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).TestAvailabilityZoneMachinesStartMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1660 +0x173
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89

Previous write at 0x00c420c9c750 by goroutine 79:
  runtime.mapassign_faststr()
      /snap/go/1404/src/runtime/hashmap_fast.go:774 +0x0
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateMachineMaps()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:346 +0x7ee
  github.com/juju/juju/worker/provisioner.(*provisionerTask).processMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:244 +0x18a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).loop()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:179 +0x55a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).(github.com/juju/juju/worker/provisioner.loop)-fm()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:111 +0x41
  github.com/juju/juju/worker/catacomb.runSafely()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:289 +0x70
  github.com/juju/juju/worker/catacomb.Invoke.func3()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:116 +0x8e

Goroutine 131 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /workspace/src/gopkg.in/check.v1/check.go:663 +0x430
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /workspace/src/gopkg.in/check.v1/check.go:754 +0x131
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /workspace/src/gopkg.in/check.v1/check.go:809 +0x42
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /workspace/src/gopkg.in/check.v1/check.go:615 +0x1fa
  gopkg.in/check%2ev1.Run()
      /workspace/src/gopkg.in/check.v1/run.go:92 +0x5a
  gopkg.in/check%2ev1.RunAll()
      /workspace/src/gopkg.in/check.v1/run.go:84 +0x136
  gopkg.in/check%2ev1.TestingT()
      /workspace/src/gopkg.in/check.v1/run.go:72 +0x680
  github.com/juju/testing.MgoTestPackage()
      /workspace/src/github.com/juju/testing/mgo.go:467 +0x120
  github.com/juju/juju/testing.MgoTestPackage()
      /workspace/src/github.com/juju/juju/testing/mgo.go:19 +0x41
  github.com/juju/juju/worker/provisioner_test.TestPackage()
      /workspace/src/github.com/juju/juju/worker/provisioner/package_test.go:13 +0x38
  testing.tRunner()
      /snap/go/1404/src/testing/testing.go:746 +0x16c

Goroutine 79 (running) created at:
  github.com/juju/juju/worker/catacomb.Invoke()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:113 +0x286
  github.com/juju/juju/worker/provisioner.NewProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:109 +0x6d1
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTaskWithRetryStrategy()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1344 +0x462
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1323 +0xe2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).TestAvailabilityZoneMachinesStartMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1660 +0x173
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89
==================
==================
WARNING: DATA RACE
Read at 0x00c4208302f8 by goroutine 131:
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateAvailabilityZoneMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:755 +0x2c2
  github.com/juju/juju/worker/provisioner.NewProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:118 +0x6f2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTaskWithRetryStrategy()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1344 +0x462
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1323 +0xe2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).TestAvailabilityZoneMachinesStartMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1660 +0x173
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89

Previous write at 0x00c4208302f8 by goroutine 79:
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateMachineMaps()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:346 +0x807
  github.com/juju/juju/worker/provisioner.(*provisionerTask).processMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:244 +0x18a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).loop()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:179 +0x55a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).(github.com/juju/juju/worker/provisioner.loop)-fm()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:111 +0x41
  github.com/juju/juju/worker/catacomb.runSafely()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:289 +0x70
  github.com/juju/juju/worker/catacomb.Invoke.func3()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:116 +0x8e

Goroutine 79 (running) created at:
  github.com/juju/juju/worker/catacomb.Invoke()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:113 +0x286
  github.com/juju/juju/worker/provisioner.NewProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:109 +0x6d1
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTaskWithRetryStrategy()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1344 +0x462
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1323 +0xe2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).TestAvailabilityZoneMachinesStartMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1660 +0x173
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89
==================
==================
WARNING: DATA RACE
Read at 0x00c4206cbe90 by goroutine 131:
  github.com/juju/juju/api/provisioner.(*Machine).InstanceId()
      /workspace/src/github.com/juju/juju/api/provisioner/machine.go:305 +0xbb
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateAvailabilityZoneMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:756 +0x301
  github.com/juju/juju/worker/provisioner.NewProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:118 +0x6f2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTaskWithRetryStrategy()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1344 +0x462
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1323 +0xe2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).TestAvailabilityZoneMachinesStartMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1660 +0x173
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89

Previous write at 0x00c4206cbe90 by goroutine 79:
  github.com/juju/juju/api/provisioner.(*State).Machines()
      /workspace/src/github.com/juju/juju/api/provisioner/provisioner.go:86 +0x3d5
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateMachineMaps()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:339 +0x400
  github.com/juju/juju/worker/provisioner.(*provisionerTask).processMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:244 +0x18a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).loop()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:179 +0x55a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).(github.com/juju/juju/worker/provisioner.loop)-fm()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:111 +0x41
  github.com/juju/juju/worker/catacomb.runSafely()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:289 +0x70
  github.com/juju/juju/worker/catacomb.Invoke.func3()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:116 +0x8e

Goroutine 79 (running) created at:
  github.com/juju/juju/worker/catacomb.Invoke()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:113 +0x286
  github.com/juju/juju/worker/provisioner.NewProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:109 +0x6d1
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTaskWithRetryStrategy()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1344 +0x462
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1323 +0xe2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).TestAvailabilityZoneMachinesStartMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1660 +0x173
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89
==================
==================
WARNING: DATA RACE
Read at 0x00c4206cbeb0 by goroutine 131:
  github.com/juju/juju/api/provisioner.(*Machine).InstanceId()
      /workspace/src/github.com/juju/juju/api/provisioner/machine.go:307 +0x1a4
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateAvailabilityZoneMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:756 +0x301
  github.com/juju/juju/worker/provisioner.NewProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:118 +0x6f2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTaskWithRetryStrategy()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1344 +0x462
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).newProvisionerTask()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1323 +0xe2
  github.com/juju/juju/worker/provisioner_test.(*ProvisionerSuite).TestAvailabilityZoneMachinesStartMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1660 +0x173
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89

Previous write at 0x00c4206cbeb0 by goroutine 79:
  github.com/juju/juju/api/provisioner.(*State).Machines()
      /workspace/src/github.com/juju/juju/api/provisioner/provisioner.go:86 +0x4a6
  github.com/juju/juju/worker/provisioner.(*provisionerTask).populateMachineMaps()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:339 +0x400
  github.com/juju/juju/worker/provisioner.(*provisionerTask).processMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:244 +0x18a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).loop()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:179 +0x55a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).(github.com/juju/juju/worker/provisioner.loop)-fm()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:111 +0x41
  github.com/juju/juju/worker/catacomb.runSafely()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:289 +0x70
  github.com/juju/juju/worker/catacomb.Invoke.func3()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:116 +0x8e

Tags:

Witold Krecicki (wpk) on 2018-02-14

Changed in juju:
assignee:	nobody → Witold Krecicki (wpk)

Revision history for this message

John A Meinel (jameinel) wrote on 2018-02-26: Re: [Bug 1749003] Re: race in provisioner test suite

Where did this get to? I think we landed the fix for it.

John
=:->

On Wed, Feb 14, 2018 at 12:41 PM, Witold Krecicki <
<email address hidden>> wrote:

> ** Changed in: juju
> Assignee: (unassigned) => Witold Krecicki (wpk)
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1749003
>
> Title:
> race in provisioner test suite
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1749003/+subscriptions
>

Witold Krecicki (wpk) on 2018-03-06

Changed in juju:
status:	Triaged → Fix Committed

Revision history for this message

Heather Lanigan (hmlanigan) wrote on 2021-10-08:

https://github.com/juju/juju/pull/8394

Changed in juju:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.