TestLoginAddsAuditConversationEventually intermittent failure
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Juju |
Fix Released
|
High
|
Anastasia | ||
2.3 |
Fix Released
|
High
|
Witold Krecicki |
Bug Description
As seen here:
http://
It would appear we are comparing against a cfg.Clock.Now() but that clock must not be a test clock, because the time difference is exactly 1s. So apparently the clock rolled over just after the code happened.
We should be using a testing clock that only changes time when we want it to.
-------
[xenial] FAIL: admin_test.go:948: loginSuite.
...
[xenial] [LOG] 0:00.304 DEBUG juju.apiserver model login: user-username-7 for deadbeef-
[xenial] [LOG] 0:00.312 INFO juju.state new machine "0" has preferred addresses: private "", public ""
[xenial] admin_test.go:992:
[xenial] c.Assert(convo, gc.Equals, auditlog.
[xenial] Who: user.Tag(
[xenial] What: "hey you guys",
[xenial] When: cfg.Clock.
[xenial] ModelName: s.IAASModel.Name(),
[xenial] ModelUUID: s.IAASModel.UUID(),
[xenial] ConnectionID: "something",
[xenial] ConversationID: "0123456789abcdef",
[xenial] })
[xenial] ... obtained auditlog.
[xenial] ... expected auditlog.
Changed in juju: | |
assignee: | nobody → Witold Krecicki (wpk) |
status: | Triaged → Fix Committed |
Changed in juju: | |
status: | Triaged → In Progress |
assignee: | Witold Krecicki (wpk) → Anastasia (anastasia-macmood) |
Changed in juju: | |
status: | In Progress → Fix Committed |
milestone: | none → 2.4-beta1 |
Changed in juju: | |
status: | Fix Committed → Fix Released |
https:/ /github. com/juju/ juju/pull/ 8281