BundleDeployCharmStoreSuite.TestAddMetricCredentials fails intermittently

Bug #1742222 reported by Heather Lanigan on 2018-01-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju
High
Anastasia

Bug Description

http://ci.jujucharms.com/job/github-merge-juju/739/console:

[xenial] ok github.com/juju/juju/cmd/juju/action 19.253s
[xenial]
[xenial] ----------------------------------------------------------------------
[xenial] FAIL: bundle_test.go:79: BundleDeployCharmStoreSuite.TestAddMetricCredentials
[xenial]
[xenial] [LOG] 0:00.003 DEBUG juju.environs.tools reading v1.* agent binaries
[xenial] [LOG] 0:00.003 INFO juju.environs.testing uploading FAKE tools 2.4-beta1-precise-amd64
...
[xenial] /home/ubuntu/juju-core_2.4-beta1/src/github.com/juju/testing/stub.go:222:
[xenial] return c.Check(funcNames, jc.DeepEquals, expected)
[xenial] ... obtained []string = []string{"Authorize", "DefaultPlan", "Authorize"}
[xenial] ... expected []string = []string{"DefaultPlan", "Authorize", "Authorize"}
[xenial] ... mismatch at [0]: unequal; obtained "Authorize"; expected "DefaultPlan"
...
[xenial] OOPS: 299 passed, 1 skipped, 1 FAILED
[xenial] --- FAIL: TestPackage (91.20s)
[xenial] FAIL
[xenial] FAIL github.com/juju/juju/cmd/juju/application 94.052s
[xenial] ok github.com/juju/juju/cmd/juju/backups 1.047s

description: updated
Changed in juju:
status: New → Triaged
tags: added: unit-tests
Changed in juju:
assignee: nobody → Anastasia (anastasia-macmood)
Changed in juju:
status: Triaged → In Progress
Anastasia (anastasia-macmood) wrote :

This happens because our testing infrastructure checks if all expected method calls were done in the predetermined order. The order of calls here is not always the same and, in fact, the order is not important to the test.

This is best fixed on both juju-testing side (to provide a check method that just checks the calls and ignores the call order) and juju side (to use new stub testing method in situations like above where the call order does not matter).

Part 1 - PR against juju/testing https://github.com/juju/testing/pull/132

Anastasia (anastasia-macmood) wrote :

Actually, removing 2.3 milestone as the change was introduced to develop (2.4) only by https://github.com/juju/juju/commit/081b5d3c0fbdfeaadfc2b5a48dfdd3abdd376b8b

no longer affects: juju/2.3
Anastasia (anastasia-macmood) wrote :

PR agaisnt develop (2.4) that fixes the actual intermittent failure: https://github.com/juju/juju/pull/8287

Changed in juju:
status: In Progress → Fix Committed
milestone: none → 2.4-beta1
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers