cinder provider fails to detach/remove if volume doesn't exist

[Andrew Wilkins]

If you create cinder storage for a charm, then remove the Cinder volume directly, then Juju will be unable to remove the volume entity. This is due to a bug in the Goose client, which misinterprets a 404 as lack of API support.

The status on the volume, as output by "juju storage --volume":

... detaching listing volume attachments: the server does not support listing attached volumes
caused by: Resource at http://<redacted>/v2/<redacted>/servers/<redacted>/os-volume_attachments not found
caused by: request (http://<redacted>/v2/<redacted>/servers/<redacted>/os-volume_attachments) returned unexpected status: 404; error info: {"itemNotFound": {"message": "The resource could not be found.", "code": 404}}

[Andrew Wilkins (axwalk)]

As is usual, the issue turns out to be a little more complicated. Goose is morphing some not-found errors in the nova API, and the cinder API is not using goose's errors at all (so the methods of determining whether an error is due to "not found" don't work). Will work on updating the cinder API to use them.

[Andrew Wilkins (axwalk)]

https://github.com/juju/juju/pull/8204

[Andrew Wilkins (axwalk)]

and https://github.com/go-goose/goose/pull/60

[Anastasia (anastasia-macmood)]

This change would have been brought over to develop (2.4-b1) in one of the regular merges from 2.3 branch.