http_proxy and no_proxy not filtered from config

[John A Meinel]

A *very* common mistake that people do when trying to interact with juju and proxies it something like:

juju bootstrap --model-default http_proxy=XXX --model-default no_proxy=YYY

however, the actual values you have to set are:
juju bootstrap --model-default http-proxy="$http_proxy" --model-default no-proxy="$no_proxy"

We should look for "http_proxy" and either provide a warning that "you really should use http-proxy" or just accept the value instead.

[John A Meinel (jameinel)]

It turns out that all providers have to directly validate "unknown" fields. Most do it naturally because that is where provider-specific configuration lives.

However, LXD didn't have any provider-specific configuration, so was missing the check.

I also updated our validation to do a simple spellcheck for getting "_" mixed up with "-".

[John A Meinel (jameinel)]

https://github.com/juju/juju/pull/7942

is the patch against 2.2

[Anastasia (anastasia-macmood)]

Since the PR in comment # 2 has been merged into 2.2 and 2.2 has since been merged into 2.3 and develop (heading into 2.4), I am marking this report as Fix Released.