Juju doesn't clean up Oracle rules

[Nicholas Skaggs]

After tearing down an instance, the following is left behind:

security rules, security lists, security protocols, access control lists, virtual NIC sets.

It seems Security Applications and IP Reservations are cleaned.

[Heather Lanigan (hmlanigan)]

(account data sanitized)

Looks like o.client.ComposeName(o.namespace.Value(machineId)) is returning an incorrect value:
DEBUG juju.provider.oracle deleting vnic set with name /Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-3d9ba2-juju-3d9ba2-0

juju-3d9ba2-juju-3d9ba2-0 vs juju-3d9ba2-0

$ source oracle.rc ; curl -s -X GET -H "Cookie: $COMPUTE_COOKIE" -H "Accept: application/oracle-compute-v3+json" $ORACLE_ENDPOINT/network/v1/vnicset/Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-3d9ba2-juju-3d9ba2-0 | python -mjson.tool
{
    "message": "no VirtualNicSet object named /Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-3d9ba2-juju-3d9ba2-0 found"
}
$ source oracle.rc ; curl -s -X GET -H "Cookie: $COMPUTE_COOKIE" -H "Accept: application/oracle-compute-v3+json" $ORACLE_ENDPOINT/network/v1/vnicset/Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-3d9ba2-0 | python -mjson.tool
{
    "appliedAcls": [
        "/Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-5e366b20-5067-4932-85c6-fe7e303d9ba2-0"
    ],
    "description": "Juju created vnic set",
    "name": "/Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-3d9ba2-0",
    "tags": [
        "juju-units-deployed=mysql/0",
        "juju-controller-uuid=6ebab07b-f317-461b-8300-adbc42e577f1",
        "juju-machine-id=default-machine-0",
        "juju-model-uuid=5e366b20-5067-4932-85c6-fe7e303d9ba2",
        "/Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-3d9ba2-0"
    ],
    "uri": "https://compute.uscom-central-1.oraclecloud.com:443/network/v1/vnicset/Compute-$ORACLE_DOMAIN/$ORACLE_USER/juju-3d9ba2-0",
    "vnics": []
}

[Heather Lanigan (hmlanigan)]

https://github.com/juju/juju/pull/8026

[Heather Lanigan (hmlanigan)]

Change to #1:

o.client.ComposeName(o.namespace.Value(machineId)), does return a correct value, just not the value required to clean up these items. They were created with a machineID of say "0", but clean up was attempted with an hostname juju-xxxxxx-0, which isn't want namespace.Value() expected.