[AWS] secgroups not cleaned up after "juju destroy-model"

[Junien F]

Hi,

With juju 2.2.2, if you create a model, deploy some units in it, and then destroy the model, the security group of the model is removed, but not the security groups assigned to each machine.

Easy repro :
 - juju bootstrap
 - juju add-model whatever
 - juju deploy cs:ubuntu
 - juju destroy-model whatever

Result : the secgroup juju-${model_uuid} is gone, but the secgroup juju-${model_uuid}-0 is still present.

Expected result : both secgroups are gone.

This was tested in ca-central-1.

Thanks

[Anastasia (anastasia-macmood)]

At the same time as addressing this bug, we should also ensure that we log clearly any secgroup manipulation failures as per bug # 1712297.