reload-spaces doesn't update space names.

[Jorge Niedbalski]

[Environment]

Juju 2.2.2
Xenial 16.04

[Description]

Internal Discussion:

<wpk> niedbalski: it's the next step - we identify the space by name so in case it is changed we need to trace all places in which it's used and change it too.
<wpk> niedbalski: it is on our roadmap.

--

Space names aren't updated after being changed in MAAS and running juju reload-spaces.

$ juju version
2.2.2-xenial-amd64

$ juju status -m controller
Model Controller Cloud/Region Version SLA
controller controller maas 2.2.2.1 unsupported

$ maas maas subnet read 5
Success.
Machine-readable output follows:
{
    "id": 5,
    "allow_proxy": true,
    "resource_uri": "/MAAS/api/2.0/subnets/5/",
    "vlan": {
        "relay_vlan": null,
        "vid": 0,
        "mtu": 1500,
        "resource_uri": "/MAAS/api/2.0/vlans/5001/",
        "space": "beans",
        "name": "untagged",
        "id": 5001,
        "fabric_id": 0,
        "dhcp_on": false,
        "fabric": "fabric-0",
        "primary_rack": null,
        "secondary_rack": null,
        "external_dhcp": null
    },
    "space": "beans",
    "active_discovery": false,
    "name": "x",
    "gateway_ip": null,
    "dns_servers": [],
    "managed": true,
    "rdns_mode": 2,
    "cidr": "x"
}

$ maas maas subnet read 10
Success.
Machine-readable output follows:
{
    "id": 10,
    "allow_proxy": true,
    "resource_uri": "/MAAS/api/2.0/subnets/10/",
    "vlan": {
        "relay_vlan": null,
        "vid": 0,
        "mtu": 1500,
        "resource_uri": "/MAAS/api/2.0/vlans/5001/",
        "space": "beans",
        "name": "untagged",
        "id": 5001,
        "fabric_id": 0,
        "dhcp_on": false,
        "fabric": "fabric-0",
        "primary_rack": null,
        "secondary_rack": null,
        "external_dhcp": null
    },
    "space": "beans",
    "active_discovery": false,
    "name": "x",
    "gateway_ip": null,
    "dns_servers": [],
    "managed": true,
    "rdns_mode": 2,
    "cidr": "x"
}

$ juju reload-spaces -m controller

# Notice that MAAS subnets 5 and 10 have "beans" as their value for "space", but
# that even after reload-spaces Juju still shows "delivery-a" and "space-0"

$ juju spaces -m controller
Space Subnets
delivery-a x
delivery-b x
            x
mgmt x
space-0 x
stg-back x
stg-front x

$ juju subnets -m controller
subnets:
  x:
    type: ipv4
    provider-id: "5"
    status: in-use
    space: delivery-a
    zones:
    - default
  x:
    type: ipv6
    provider-id: "10"
    status: in-use
    space: space-0
    zones:
    - default

[Drew Freiberger (afreiberger)]

Tagging canonical-bootstack as we run into this when troubleshooting a deployment and not wanting to destroy the live-working model for a single space addition or rename for one or two charms.

[Tim Penhey (thumper)]

Taking the milestone off as to not set unrealistic expectations.

This work needs a bunch of internal networking storage updates inside Juju. These have been punted from the roadmap for at least the last three cycles becuase it isn't important enough.

We need to raise the internal priority for this piece of work.