Agent.conf upgradedToVersion field not updated on upgrade

[Jorge Niedbalski]

[Environment]

Xenial
Juju 2.2.2

[Description]

$ juju upgrade-juju -m controller --agent-version='2.2.2'

- Check /var/lib/juju/agents/machine-XX/agent.conf value has been set to
upgradedToVersion: 2.2.2.

- Same check for /var/lib/juju/agents/unit-*/agent.conf keeps
referring the previous release upgradedToVersion: 2.1.3

The upgrade seems successful except from this field on the agent.conf.

[John A Meinel (jameinel)]

It sounds like you upgraded the controller but not the models. Are you
having units in the controller model? Or is this a case of needing to also
run "juju upgrade-juju -m default" (or any other model name you have
created)

John
=:->

On Jul 18, 2017 22:21, "Jorge Niedbalski" <email address hidden>
wrote:

> ** Summary changed:
>
> - Agent.conf upgradedToVersion field not updated on upgrades
> + Agent.conf upgradedToVersion field not updated on upgrade
>
> ** Description changed:
>
> [Environment]
>
> - Xenial
> + Xenial
> Juju 2.2.2
>
> [Description]
>
> -
> - $ juju upgrade-juju -m controller --agent-version='2.2.2'
> + $ juju upgrade-juju -m controller --agent-version='2.2.2'
>
> - Check /var/lib/juju/agents/machine-XX/agent.conf value has been set to
> upgradedToVersion: 2.2.2.
>
> - - Same check for /var/lib/juju/agents/unit-*/agent.conf keeps in
> + - Same check for /var/lib/juju/agents/unit-*/agent.conf keeps
> referring the previous release upgradedToVersion: 2.1.3
>
> The upgrade seems successful except from this field on the agent.conf.
>
> ** Tags added: sts
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1705112
>
> Title:
> Agent.conf upgradedToVersion field not updated on upgrade
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1705112/+subscriptions
>

[Anastasia (anastasia-macmood)]

@Jorge Niedbalski (niedbalski),

From John's comment, the units on "controller" model should have "upgradedToVersion: 2.2.2" after you ran "juju upgrade-juju -m controller --agent-version='2.2.2'"...

Could you please clarify whether "2.1.3" is on the units in that model or a different, possibly not-yet-upgraded, model?

[Doug Parrish (dparrish)]

@Anastasia - I opened the case which spawned this bug report.

The agent.conf for each machine agent in the model get updated with the new tools version; yet, none of the unit agents' agent.conf get updated. This occurs whether the model is 'controller' or 'default'. Also, the tools:version field of the units collection in MongoDB does indeed get updated, though with a slightly different string: "2.2.2.1-xenial-amd64" versus "2.2.2.1" in agent.conf. The upgrade-juju process appears to complete successfully.

[Doug Parrish (dparrish)]

This deficiency occurs in Juju 2.2.3 as well

[Felipe Reyes (freyes)]

Anastasia, here you can see how the default and controller models were upgraded from 2.1.3 to 2.2.3 and as doug previously mentioned the agent.conf was not updated

Steps:

  juju bootstrap ...
  juju deploy -n 3 cs:ubuntu
  juju upgrade-juju -m controller --agent-version=2.2.3
  juju show-model controller
  juju upgrade-juju -m default --agent-version=2.2.3
  juju show-model default

ubuntu@juju-2pt2:~$ juju ssh 0 sudo cat /var/lib/juju/agents/unit-ubuntu-0/agent.conf
# format 2.0
tag: unit-ubuntu-0
datadir: /var/lib/juju
logdir: /var/log/juju
metricsspooldir: /var/lib/juju/metricspool
nonce: unused
upgradedToVersion: 2.1.3
cacert: |
  -----BEGIN CERTIFICATE-----
  MIIDzTCCArWgAwIBAgIUJpaXcqEiOJDChdmOIoIs7/XE1zgwDQYJKoZIhvcNAQEL
  BQAwbjENMAsGA1UEChMEanVqdTEuMCwGA1UEAwwlanVqdS1nZW5lcmF0ZWQgQ0Eg
  Zm9yIG1vZGVsICJqdWp1LWNhIjEtMCsGA1UEBRMkM2UyZjk3OTQtMTQ3NC00NTZm
  LTg5OWUtNzAwMmJhMjBlMjA4MB4XDTE3MDkwNTE0MzE1NFoXDTI3MDkxMjE0MzE1
  M1owbjENMAsGA1UEChMEanVqdTEuMCwGA1UEAwwlanVqdS1nZW5lcmF0ZWQgQ0Eg
  Zm9yIG1vZGVsICJqdWp1LWNhIjEtMCsGA1UEBRMkM2UyZjk3OTQtMTQ3NC00NTZm
  LTg5OWUtNzAwMmJhMjBlMjA4MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC
  AQEAshc4Lkjr01PGYmvXcFcKd7BktAtBvCYKrqm3W2jyBfjur78tkIe2bgLGjW8q
  rIrAKiFFQ8GPxbRtGNBoLjDhLJV81bA8SNO8vHutE4QD5AB7eko6Io4gi2wYdAHp
  bOfVDVKe4YeUHXbakSZAWmKzUyTlewmjVpKUv8Kage4BlKfFQgRjKBHrX5Dp+H1N
  SePqsSYznL4saMHf/qtOAvp/bLSKgtKJ45tvQm537XdArEB2qaK7Pjhu7RxkydIA
  GgKiH1n8CHiY1KVoO+3bPIHd70BZC54T4jT9nDEIQsxo5Or+DPFCYDXt+LbyvuY1
  y1tgbcKOLUbkRTx0wkKLoE9Z+QIDAQABo2MwYTAOBgNVHQ8BAf8EBAMCAqQwDwYD
  VR0TAQH/BAUwAwEB/zAdBgNVHQ4EFgQU82badu3HtqXorfP6V/GttfLQhY8wHwYD
  VR0jBBgwFoAU82badu3HtqXorfP6V/GttfLQhY8wDQYJKoZIhvcNAQELBQADggEB
  AKPoachUVRffYNUXokNPYuvqkXmT9P4XB+gCBLlAAKFIouJCDH+LaNobBBYeR/Wz
  i/FqG/kO2i328D1NmmALrgE5JjfDtABlSktHBTV1I1RgAcM2o9ZRP1EHXn7xtXBO
  PXuHfYVc2fCXJavKceENFXCxFFlxMpwFDi4w7yK6Bt3rm2xNgrkCdYK7if4gcwr9
  pGFZFMbkBU9XDO1xe5mzCvnrzdroJ3OJjgbZ0QoPmnEJl6IJSisoso00VwuQdIq+
  xVsaGCLZPDVuwJnV+ClV61t9BLIMoEJ0zJKa0C8aXPO+g3NDVJtr2lKlSYsQhiWP
  6K730jQbvqQJa+wicmBUHHw=
  -----END CERTIFICATE-----
stateaddresses:
- 10.5.1.106:37017
statepassword: +tjyRSJjYM8pZe2Nok33Gygy
controller: controller-c40c11a4-d4fa-420b-8be4-3fc6ab4c2f59
model: model-7707aaa4-39a5-4bd1-8179-70abd08201ba
apiaddresses:
- 10.5.1.106:17070
- 10.230.70.83:17070
apipassword: +tjyRSJjYM8pZe2Nok33Gygy
oldpassword: vyhsnCPIQrXJTkJwUDAlo5Q0
loggingconfig: <root>=INFO;unit=DEBUG
values:
  CONTAINER_TYPE: ""
  NAMESPACE: ""
mongoversion: "0.0"
Connection to 10.230.70.94 closed.
ubuntu@juju-2pt2:~$ juju status
Model Controller Cloud/Region Version SLA
default c2 stsstack/stsstack 2.2.3 unsupported

App Version Status Scale Charm Store Rev OS Notes
ubuntu 16.04 active 3 ubuntu jujucharms 10 ubuntu

Unit Workload Agent Machine Public address Ports Message
ubuntu/0* active idle 0 10.230.70.94 ready
ubuntu/1 active idle 1 10.230.70.95 ready
ubuntu/2 active idle 2 10.230.70.96 ready

Machine State DNS Inst id Series AZ Message
0 started 10.230.70.94 9d...

[Anastasia (anastasia-macmood)]

PR against develop (2.3-beta2): https://github.com/juju/juju/pull/7923