charm-revision-updater doesn't handle non-JSON response content

Bug #1703615 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Triaged
Low
Unassigned

Bug Description

It seems the charm store went offline for a period of time. It was returning a 503 Service Unavailable, but rather than handling the HTTP status code, the code assumes that all responses will be valid JSON and aborts because "<html>" isn't valid JSON.

machine-0: 17:57:39 ERROR juju.worker.dependency "charm-revision-updater" manifold worker returned unexpected error: while getting latest charm revision info: cannot get metadata from the charm store: cannot unmarshal error response "<html><body><h1>503 Service Unavailable</h1>\nNo server is available to handle this request.\n</body></html>\n": invalid character '<' looking for beginning of value

Revision history for this message
John A Meinel (jameinel) wrote :

Note also that ones the 'charm-revision-updater' gets this error, it fails the worker, which then bounces and restarts 1 second later, which fails in the same way.

We should treat 503 significantly more gracefully than we do.

Ian Booth (wallyworld)
tags: added: charmhub
removed: charm-store
Revision history for this message
Canonical Juju QA Bot (juju-qa-bot) wrote :

This Medium-priority bug has not been updated in 60 days, so we're marking it Low importance. If you believe this is incorrect, please update the importance.

Changed in juju:
importance: Medium → Low
tags: added: expirebugs-bot
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.