juju assumes bond interfaces named with "bond" prefix

Bug #1692611 reported by JuanJo Ciarlante
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Jack Shaw

Bug Description

As per:

https://github.com/juju/juju/blob/master/provider/maas/interfaces.go#L132
  [...] strings.HasPrefix(children, "bond")
, juju is assuming bond interfaces to be named with
"bond" prefix, which is is inaccurate as Linux interfaces
can have arbitrary names (besides e.g. maas defaulting
to bondX names for bonds).

Couple possible ways to fix it:

$ ethtool -i bond-mgmt
driver: bonding

$ test -d /sys/class/net/bond-mgmt/bonding && echo yes
yes

JuanJo Ciarlante (jjo)
description: updated
Changed in juju:
importance: Undecided → High
status: New → Triaged
tags: added: bitesize
tags: added: maas-provider network
Revision history for this message
John A Meinel (jameinel) wrote :

I believe this only applies to the 1.9 version of the code path for network interfaces. And I believe that code should be removed in the 3.0 branch, so no longer applies at all.

Changed in juju:
status: Triaged → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for juju because there has been no activity for 60 days.]

Changed in juju:
status: Incomplete → Expired
Revision history for this message
Haw Loeung (hloeung) wrote :

Is "develop" 3.0? I think so from https://github.com/juju/juju/blob/develop/version/version.go#L24:

| const version = "3.0-beta1"

If so, it still has code that checks if bonded interfaces begin with "bond" - https://github.com/juju/juju/blob/develop/provider/maas/interfaces.go#L171:

| if parentName == "" && len(iface.Children()) == 1 && strings.HasPrefix(children, "bond") {

Changed in juju:
status: Expired → New
Changed in juju:
status: New → Triaged
assignee: nobody → Jack Shaw (jack-shaw)
milestone: none → 2.9.22
Changed in juju:
status: Triaged → In Progress
Jack Shaw (jack-shaw)
Changed in juju:
status: In Progress → Fix Committed
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.