Race in github.com/juju/juju/worker/peergrouper

[Curtis Hovey]

As seen at
    http://reports.vapour.ws/releases/issue/58a489f3749a564e0d69aa3d

There is a data race in github.com/juju/juju/worker/peergrouperWARNING: DATA RACE
Read by goroutine 72:
  github.com/juju/juju/worker/peergrouper.(*workerSuite).TestSetsAndUpdatesMembers.func1.1()
      /home/ubuntu/juju-core_2.2-alpha1/src/github.com/juju/juju/worker/peergrouper/worker_test.go:154 +0xba

Previous write by goroutine 99:
  github.com/juju/juju/worker/peergrouper.(*workerSuite).newNoPublishWorker()
      /home/ubuntu/juju-core_2.2-alpha1/src/github.com/juju/juju/worker/peergrouper/worker_test.go:784 +0x17f
  github.com/juju/juju/worker/peergrouper.(*workerSuite).TestSetsAndUpdatesMembers.func1()
      /home/ubuntu/juju-core_2.2-alpha1/src/github.com/juju/juju/worker/peergrouper/worker_test.go:140 +0x41d
  github.com/juju/juju/worker/peergrouper.DoTestForIPv4AndIPv6()
      /home/ubuntu/juju-core_2.2-alpha1/src/github.com/juju/juju/worker/peergrouper/worker_test.go:66 +0x94
  github.com/juju/juju/worker/peergrouper.(*workerSuite).TestSetsAndUpdatesMembers()
      /home/ubuntu/juju-core_2.2-alpha1/src/github.com/juju/juju/worker/peergrouper/worker_test.go:204 +0x120
  runtime.call32()
      /usr/lib/go-1.6/src/runtime/asm_amd64.s:472 +0x3d
  reflect.Value.Call()
      /usr/lib/go-1.6/src/reflect/value.go:303 +0xcd
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/ubuntu/juju-core_2.2-alpha1/src/gopkg.in/check.v1/check.go:772 +0x5d1
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/ubuntu/juju-core_2.2-alpha1/src/gopkg.in/check.v1/check.go:666 +0x80

Goroutine 72 (running) created at:
  github.com/juju/juju/worker/peergrouper.(*workerSuite).TestSetsAndUpdatesMembers.func1()
      /home/ubuntu/juju-core_2.2-alpha1/src/github.com/juju/juju/worker/peergrouper/worker_test.go:159 +0x49b
  github.com/juju/juju/worker/peergrouper.DoTestForIPv4AndIPv6()
      /home/ubuntu/juju-core_2.2-alpha1/src/github.com/juju/juju/worker/peergrouper/worker_test.go:65 +0x5f
  github.com/juju/juju/worker/peergrouper.(*workerSuite).TestSetsAndUpdatesMembers()

[Anastasia (anastasia-macmood)]

There seems to be only one occurrence of this failure on master branch on Feb 15. Current development branches - 2.1 and develop for 2.2 - do not exhibit this behavior.

The issue may have been fixed and the fix is going to be in master once development branches are promoted.

I'll mark this bug as Incomplete for now. Feel free to re-open if failure will re-occur after branch promotion.

[Andrew Wilkins (axwalk)]

https://github.com/juju/juju/pull/7412