Machine.SetInstanceStatus not strict on status

[John A Meinel]

If you look at Machine.SetStatus it explicitly checks what values you're allowed to pass to it, and certain states are not allowed at certain times.
Machine.SetInstanceStatus has no such safeguards, which means it is very easy to pass an InstanceStatus that isn't in the expected set of states.

Consider adding something like the attached patch.

Obviously you also need to deal with the fallout. One of the key pieces is that *many* code paths actually pass status.Pending, we need to confirm if that is a legitimate status, and how it differs from status.Provisioning. According to the original design document, Pending was not one of the official states.

[John A Meinel (jameinel)]

Strict SetInstanceStatus states.

[Anastasia (anastasia-macmood)]

As this is a tech-debt item, I am lowering its Importance.

[Canonical Juju QA Bot (juju-qa-bot)]

This bug has not been updated in 5 years, so we're marking it Expired. If you believe this is incorrect, please update the status.