interactive add-cloud does not reject invalid cloud names

Bug #1641981 reported by Aaron Bentley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Won't Fix
High
Unassigned

Bug Description

According to the SRS doc:
  System must handle invalid cloud names
  https://docs.google.com/document/d/1K2QPcdrsxAKpKEWT7RiRT-pL-D3LrLzl3QomVimKxAo/edit#

There is no specification of what cloud names are valid or invalid, but I believe that a name containing slash is invalid, because slash is used as a separator between cloud and region.

Names containing slash are not rejected, but they cannot be used, even though add-cloud gives example usage as though they can:
$ juju add-cloud
Cloud Types
  maas
  manual
  openstack
  vsphere

Select cloud type: manual

Enter a name for the cloud: foo/region

Enter the controller's hostname or IP address: asdf

Cloud "foo/region" successfully added
You may bootstrap with 'juju bootstrap foo/region'
$ juju bootstrap foo/region
ERROR unknown cloud "foo", please try "juju update-clouds"

I have also tried arbitrary unicode unicode characters such as "∃", and they are also accepted.

Revision history for this message
Nate Finch (natefinch) wrote :

There's nothing wrong with allowing unicode, but you're right that if we use slash as a delimiter, we need to prevent people from making cloud names with that character, or give them a way to escape it... probably the former.

Revision history for this message
Richard Harding (rharding) wrote :

We've talked and agreed that Juju provides a naming limitation across the product and keeping to that standard vs guessing what can be used for what names where in Juju is a good way to go.

Changed in juju:
assignee: nobody → Richard Harding (rharding)
Changed in juju:
assignee: Richard Harding (rharding) → nobody
Revision history for this message
Anastasia (anastasia-macmood) wrote :

Removing 2.1 milestone as we will not be addressing this issue in 2.1.

Changed in juju:
milestone: 2.1-rc2 → none
Revision history for this message
Heather Lanigan (hmlanigan) wrote :

Resolved at some point...

Enter a name for your manual cloud: cloud/foo
Invalid name. Valid names start with a letter, and use only letters, numbers, hyphens, and underscores:

Changed in juju:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.