interactive add-cloud does not validate endpoint urls

Bug #1641970 reported by Aaron Bentley on 2016-11-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju
Medium
Unassigned

Bug Description

Interactive add-cloud does not ensure that the supplied endpoints are valid urls.

I tried with unicode ∃ and ≄, which are not even ASCII, much less valid URLs, and both were accepted:

$ juju add-cloud
Cloud Types
  maas
  manual
  openstack
  vsphere

Select cloud type: ∃
Invalid cloud type: "∃"

Select cloud type: maas

Enter a name for the cloud:

Enter a name for the cloud: ∃

Enter the API endpoint url: ∃

Cloud "∃" successfully added
You may bootstrap with 'juju bootstrap ∃'
$ juju add-cloud
Cloud Types
  maas
  manual
  openstack
  vsphere

Select cloud type: openstack

Enter a name for the cloud: ≄

Enter the API endpoint url for the cloud: ≄

Auth Types
  oauth1
  oauth2
  access-key
  userpass

Select one or more auth types separated by commas: oauth2

Enter region name: ∃

Enter the API endpoint url for the region: ∃

Enter another region? (Y/n): n

Cloud "≄" successfully added
You may bootstrap with 'juju bootstrap ≄'

Aaron Bentley (abentley) on 2016-11-15
Changed in juju:
milestone: none → 2.1.0
Aaron Bentley (abentley) wrote :

Upgraded to srs because it says juju must "error if a cloud endpoint is not reachable from the client", and an invalid URL is never reachable by the client. It could still be addressed by causing juju to error on unreachable URLs instead of invalid URLs in particular.

tags: added: srs
Changed in juju:
assignee: nobody → Nate Finch (natefinch)
status: Triaged → In Progress
Changed in juju:
status: In Progress → Triaged
assignee: Nate Finch (natefinch) → nobody
milestone: 2.1.0 → 2.2.0
Curtis Hovey (sinzui) on 2017-03-24
Changed in juju:
milestone: 2.2-beta1 → 2.2-beta2
Curtis Hovey (sinzui) on 2017-03-30
Changed in juju:
milestone: 2.2-beta2 → 2.2-beta3
Changed in juju:
milestone: 2.2-beta3 → 2.2-beta4
Changed in juju:
milestone: 2.2-beta4 → 2.2-rc1
Tim Penhey (thumper) on 2017-05-31
Changed in juju:
milestone: 2.2-rc1 → none
importance: High → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers