Race in github.com/juju/juju/api/client

Bug #1630835 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Unassigned

Bug Description

As seen in
    http://reports.vapour.ws/releases/issue/57f5b671749a5652fef1c01c

WARNING: DATA RACE
Read by goroutine 135:
  net/http.(*Request).closeBody()
      /usr/lib/go-1.6/src/net/http/request.go:1075 +0x33
  net/http.(*persistConn).writeLoop()
      /usr/lib/go-1.6/src/net/http/transport.go:1289 +0x426

Previous write by goroutine 7:
  gopkg.in/macaroon-bakery.v1/httpbakery.(*Client).setRequestBody()
      /home/ubuntu/juju-core_2.0-rc3/src/gopkg.in/macaroon-bakery.v1/httpbakery/client.go:397 +0x233
  gopkg.in/macaroon-bakery.v1/httpbakery.(*Client).doWithBody()
      /home/ubuntu/juju-core_2.0-rc3/src/gopkg.in/macaroon-bakery.v1/httpbakery/client.go:286 +0x78a
  gopkg.in/macaroon-bakery.v1/httpbakery.(*Client).DoWithBodyAndCustomError()
      /home/ubuntu/juju-core_2.0-rc3/src/gopkg.in/macaroon-bakery.v1/httpbakery/client.go:245 +0x212
  github.com/juju/juju/api.httpRequestDoer.DoWithBody()
      /home/ubuntu/juju-core_2.0-rc3/src/github.com/juju/juju/api/http.go:103 +0x406
  github.com/juju/httprequest.(*Client).Do()
      /home/ubuntu/juju-core_2.0-rc3/src/github.com/juju/httprequest/client.go:167 +0x582
  github.com/juju/juju/api.(*Client).httpPost()
      /home/ubuntu/juju-core_2.0-rc3/src/github.com/juju/juju/api/client.go:481 +0x212
  github.com/juju/juju/api.(*Client).UploadCharm()
      /home/ubuntu/juju-core_2.0-rc3/src/github.com/juju/juju/api/client.go:314 +0x869
  github.com/juju/juju/api.(*Client).AddLocalCharm()
      /home/ubuntu/juju-core_2.0-rc3/src/github.com/juju/juju/api/client.go:297 +0x362
  github.com/juju/juju/api_test.(*clientMacaroonSuite).TestAddLocalCharmUnauthorized()
      /home/ubuntu/juju-core_2.0-rc3/src/github.com/juju/juju/api/client_macaroon_test.go:81 +0x391
  runtime.call32()
      /usr/lib/go-1.6/src/runtime/asm_amd64.s:472 +0x3d
  reflect.Value.Call()
      /usr/lib/go-1.6/src/reflect/value.go:303 +0xcd
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/ubuntu/juju-core_2.0-rc3/src/gopkg.in/check.v1/check.go:772 +0x5d1
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/ubuntu/juju-core_2.0-rc3/src/gopkg.in/check.v1/check.go:666 +0x80

Curtis Hovey (sinzui)
Changed in juju:
milestone: 2.0-rc3 → 2.0.0
Changed in juju:
milestone: 2.0.0 → 2.0.1
Curtis Hovey (sinzui)
Changed in juju:
milestone: 2.0.1 → none
Curtis Hovey (sinzui)
Changed in juju:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.