Unit tests for acl controls

[Nicholas Skaggs]

In response to bug 1613688 and other bugs like it, it would be useful to have complete coverage for all acl actions within the juju unit tests. ACL's are very important being a security feature, and will see more and more use. We need to ensure we've tested all possible scenarios and I believe this will be most efficiently done inside a unit test.

[Anastasia (anastasia-macmood)]

@Nicholas,

Here is current unit test coverage for ACL on master:
    * github.com/juju/juju/api/modelmanager: 80.0% of statements
    * github.com/juju/juju/apiserver/modelmanager: 78.6% of statements
    * github.com/juju/juju/cmd/juju/model: 67.1% of statements

Are you asking for 100% coverage?
If not, please be more specific what unit tests you'd like to see :D

[Nicholas Skaggs (nskaggs)]

I'm not asking for 100% coverage. I'd like to ensure we have tests that check specifically for the issue noted in bug 1613688. In addition, I would like to ensure we have tests that cover similar scenarios -- we need to be assured limited roles don't have a way of performing admin functions. A least a basic exercising of the security granted should be tested. In looking at the current coverage I'm not convinced we are thorough enough. For example, I don't see any negative tests asserting limited users cannot perform admin roles.

[Christopher Lee (veebers)]

Adding for EDA coverage:

  - https://bugs.launchpad.net/juju/+bug/1616167
  - https://bugs.launchpad.net/juju/+bug/1616169

[Horacio Durán (hduran-8)]

I proposed https://github.com/juju/juju/pull/6384