one badly formed credential makes bootstrap fail

[Nate Finch]

I have a credentials.yaml file that looks like this:

credentials:
  azure:
    ci-creds:
      auth-type: userpass
      # secrets etc
  google:
    nate:
      auth_type: jsonfile
      file: /home/nate/google.json

Note that google/nate credential has a typo in that auth_type should be auth-type.

This on malformed entry in credentials.yaml causes bootstrap to fail. In fact, even bootstrap --clouds fails:

$ juju bootstrap --clouds
You can bootstrap on these clouds. See ‘--regions <cloud>’ for all regions.
ERROR error loading credential for cloud "aws": credentials.google.nate: missing auth-type

^^ why does the aws cloud care what my google credentials are?

In fact, I can't bootstrap at all:

$ juju bootstrap lxd lxd
ERROR loading credentials: credentials.google.nate: missing auth-type

If I'm bootstrapping lxd, why does juju care if I have a badly formed credential for the cloud named google?

Maybe print a warning, sure... but just failing seems a bit extreme.

Also, there's absolutely no indication of how to fix the problem. As a developer, I luckily realized that I should look at my credentials.yaml file, but a user wouldn't know to do that from that error message.

[Harry Pidcock (hpidcock)]

https://github.com/juju/juju/pull/10284