ActionSuite.TestUnitWatchActionNotifications unexpected change

[Nicholas Skaggs]

As seen in http://reports.vapour.ws/releases/issue/5755c655749a5635f691f49d:

FAIL: action_test.go:564: ActionSuite.TestUnitWatchActionNotifications

SetUpTest
[LOG] 0:00.035 INFO juju.state opening state, mongo addresses: ["localhost:40297"]; entity <nil>
[LOG] 0:00.036 DEBUG juju.state dialing mongo
[LOG] 0:00.046 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:40297"
[LOG] 0:00.048 DEBUG juju.state connection established
[LOG] 0:00.048 DEBUG juju.state mongodb login successful
[LOG] 0:00.105 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:40297"
[LOG] 0:00.108 INFO juju.state initializing controller model 581930c0-0a00-4900-8b6f-2f16a326cc0c
[LOG] 0:00.225 INFO juju.state running state anonymously; using unique client id
[LOG] 0:00.225 INFO juju.state starting standard state workers
[LOG] 0:00.225 DEBUG juju.state.workers starting leadership lease manager
[LOG] 0:00.232 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:40297"
[LOG] 0:00.255 DEBUG juju.state.workers starting singular lease manager
[LOG] 0:00.255 DEBUG juju.worker.lease waking to check leases at 2016-06-03 15:00:17.699756148 +0000 UTC
[LOG] 0:00.271 DEBUG juju.state.workers starting transaction log watcher
[LOG] 0:00.272 DEBUG juju.state.workers starting presence watcher
[LOG] 0:00.274 INFO juju.state creating cloud image metadata storage
[LOG] 0:00.274 INFO juju.state started state for model-581930c0-0a00-4900-8b6f-2f16a326cc0c successfully
SetUpTest done
[LOG] 0:00.276 DEBUG juju.worker.lease waking to check leases at 2016-06-03 15:00:17.720381223 +0000 UTC
[LOG] 0:00.289 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:40297"
[LOG] 0:00.875 DEBUG juju.state.action newActionDoc name: 'snapshot', receiver: 'unit-dummy-0', actionId: 'e6eac22e-7cb3-4531-89f9-6cba37b668e4'
[LOG] 0:00.901 DEBUG juju.state.action newActionDoc name: 'snapshot', receiver: 'unit-dummy-0', actionId: 'caebf281-64be-4882-83d7-623f56d28891'
action_test.go:587:
    wc.AssertNoChange()
testing/watcher.go:145:
    c.Fatalf("watcher sent unexpected change: (%v, %v)", actual, ok)
... Error: watcher sent unexpected change: ([e6eac22e-7cb3-4531-89f9-6cba37b668e4 caebf281-64be-4882-83d7-623f56d28891], true)

While this issue is not a race, it appears only when the tests are run with race.

[Anastasia (anastasia-macmood)]

PR against develop: https://github.com/juju/juju/pull/6574

[Anastasia (anastasia-macmood)]

PR against 2.0: https://github.com/juju/juju/pull/6608