Panic on bundle with local charm and no series

[Martin Packman]

Deploying a bundle where the series of a local charm is not explict results in a juju panic:

<http://juju-ci.vapour.ws/job/rackspace-deploy-bundle/118/console>

panic: charm or bundle URL has invalid form: "./trusty/haproxy"

goroutine 1 [running]:
panic(0x1e26620, 0xc8204f5960)
 /usr/lib/go-1.6/src/runtime/panic.go:464 +0x3e6
gopkg.in/juju/charm%2ev6-unstable.MustParseURL(0xc820303220, 0x10, 0x7f899fb70000)
 /workspace/juju-core-2.0-rc1/src/gopkg.in/juju/charm.v6-unstable/url.go:97 +0x72
github.com/juju/bundlechanges.getSeries(0xc82045bc00, 0xc820303358, 0x6, 0x0, 0x0)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/bundlechanges/handlers.go:263 +0x156
github.com/juju/bundlechanges.handleServices(0xc820108cd8, 0xc8204c6960, 0xc820303358, 0x6, 0x7ffec6e1e937)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/bundlechanges/handlers.go:34 +0x3dd
github.com/juju/bundlechanges.FromData(0xc8201369c0, 0x0, 0x0, 0x0)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/bundlechanges/changes.go:17 +0x8f
github.com/juju/juju/cmd/juju/service.deployBundle(0x7ffec6e1e937, 0x1b, 0xc8201369c0, 0x0, 0x0, 0xc8204c6630, 0xc8204c9820, 0xc8204f57e0, 0x7f899fbbb0c0, 0xc8203744b0, ...)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/juju/cmd/juju/service/bundle.go:90 +0x3f3
github.com/juju/juju/cmd/juju/service.(*DeployCommand).deployCharmOrBundle(0xc8203201c0, 0xc8203744b0, 0xc8204c6630, 0x0, 0x0)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/juju/cmd/juju/service/deploy.go:422 +0x12a7
github.com/juju/juju/cmd/juju/service.(*DeployCommand).Run(0xc8203201c0, 0xc8203744b0, 0x0, 0x0)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/juju/cmd/juju/service/deploy.go:755 +0xb9
github.com/juju/juju/cmd/modelcmd.(*modelCommandWrapper).Run(0xc82038b5f0, 0xc8203744b0, 0x0, 0x0)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/juju/cmd/modelcmd/modelcommand.go:273 +0x4f
github.com/juju/juju/cmd/modelcmd.(*baseCommandWrapper).Run(0xc8201d8f50, 0xc8203744b0, 0x0, 0x0)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/juju/cmd/modelcmd/base.go:205 +0xd4
github.com/juju/cmd.(*SuperCommand).Run(0xc8201dd700, 0xc8203744b0, 0x0, 0x0)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/cmd/supercommand.go:446 +0x688
github.com/juju/cmd.Main(0x7f899fbb6210, 0xc8201dd700, 0xc8203744b0, 0xc82006e070, 0x5, 0x5, 0x25fe810)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/cmd/cmd.go:280 +0x2f0
github.com/juju/juju/cmd/juju/commands.Main(0xc82006e060, 0x6, 0x6)
 /workspace/juju-core-2.0-rc1/src/github.com/juju/juju/cmd/juju/commands/main.go:83 +0x506
main.main()
 /workspace/juju-core-2.0-rc1/src/github.com/juju/juju/cmd/juju/main.go:27 +0x3b

This isn't the nicest feedback to the user to tell them they need to specify a series.

A bundle in the following sort of form should reproduce:

machines:
  "1":
    series: trusty
  haproxy:
    charm: "./trusty/haproxy"
    num_units: 1
    to:
      - "2"

Add 'series: trusty' under 'haproxy' and juju succeeds.

[Trent Lloyd (lathiat)]

This bug is related: https://bugs.launchpad.net/juju/+bug/1579849

[Joseph Phillips (manadart)]

Marking "won't fix" due to age and unsupported version.