Invalid storage returned by storage-list causing charm breakage

[Ian Booth]

When adding storage that is invalid (over size limits), charms can break.

For example:

juju switch amazon
juju bootstrap
juju deploy cs:~chris.macnaughton/trusty/ceph-osd --storage "osd-devices=ebs,2T,1"
juju destroy-service ceph-osd

storage-list will return the invalid attachments, causing :

storage_ids = storage_list('osd-devices')
devices.extend((storage_get('location', s) for s in storage_ids))

to break within a charm environment.

[Andrew Wilkins (axwalk)]

can you please provide the error text? what version of juju are you using?

[Andrew Wilkins (axwalk)]

I think this is solved when lp:1501709 is fixed

[Chris MacNaughton (chris.macnaughton)]

The only time I've seen this happen is when adding a LOT of storage devices to the ceph charm with storage hooks. The charm iterates through the results of storage-list instead of just adding the device currently in the hook. What this seems to cause is the last device not being attached with the first device's attaching hook fires.