apiserver: Digest SHA header is incorrectly formed
Bug #1503992 reported by
Roger Peppe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical Juju |
Fix Released
|
High
|
Ian Booth | ||
Bug Description
The DigestAlgorithm type specifies a constant "SHA" (which according
to RFC 3230 means the SHA1 algorithm), but then images.go
in apiserver sets an SHA-256 checksum associated with this
which is hexadecimal not base64-encoded as required by the standard.
As Juju itself ignores the Digest header entirely on the client side,
this is not a problem in itself, but it should be fixed to correctly
adhere to the standard that the code refers to.
| Changed in juju-core: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 1.26-alpha1 |
| tags: | added: api |
| Changed in juju-core: | |
| milestone: | 1.26-alpha1 → 1.26-alpha2 |
| Changed in juju-core: | |
| milestone: | 1.26-alpha2 → 1.26-beta1 |
| Changed in juju-core: | |
| milestone: | 1.26-beta1 → 2.0-alpha2 |
| Changed in juju-core: | |
| milestone: | 2.0-alpha2 → 2.0-alpha3 |
| Changed in juju-core: | |
| milestone: | 2.0-alpha3 → 2.0-beta4 |
Revision history for this message
| Anastasia (anastasia-macmood) wrote | #1 |
| Changed in juju-core: | |
| assignee: | nobody → Anastasia (anastasia-macmood) |
| status: | Triaged → In Progress |
| Changed in juju-core: | |
| assignee: | Anastasia (anastasia-macmood) → nobody |
| status: | In Progress → Triaged |
| milestone: | 2.0-beta4 → 2.0-rc1 |
| Changed in juju-core: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| status: | Triaged → In Progress |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
| affects: | juju-core → juju |
| Changed in juju: | |
| milestone: | 2.0-beta5 → none |
| milestone: | none → 2.0-beta5 |
To post a comment you must log in.
DigestAlgorithm constant should reflect that we are using sha256 and be "SHA-256" (rfc5843). This will affect the protocol.