uniter_test.go, startUpgradeError{} fails for windows

[Tim Penhey]

The initial part of this step is to do the following:

  appendHook(c, path, "start", "chmod 555 $CHARM_DIR")

Now chmod isn't going to work on windows.

I tried the windows equivalent:

     permChange := ("icacls %CHARM_DIR% /grant:r everyone:R\n" +
      "icacls %CHARM_DIR% /inheritance:r\n")
     appendHook(c, path, "start", permChange)

However that didn't have the desired effect of having the unit in an error state.

So, skipping the particular test in uniter_test.go for windows for now.

[Bogdan Teleaga (bteleaga)]

So I don't think file permissions is the way to go here. They're probably not checked on windows
 There needs to be another way we can fail the upgrade.

[Anastasia (anastasia-macmood)]

Removing 2.1 milestone as we will not be addressing this issue in 2.1.