state.SetEnvironConfig should take old and new config values

[Tim Penhey]

We should pass in both the old and new config to SetEnvironConfig in order to determine changes.

Then conditions could be added to the update to make sure that we aren't updating something that someone else has tweaked in the mean time, and that we wouldn't wipe out someone else's changes.

[Andrew Wilkins (axwalk)]

I need to be able to remove config keys from state to test secrets-pushing, so I'll take a look at this.

[Andrew Wilkins (axwalk)]

I've done the first bit: SetEnvironConfig now takes old and new configs. It doesn't do a full delta, but it does now delete things that are in old but not new.

Leaving this open to finish off - that's a bit more work.

[William Reade (fwereade)]

See lp:1168744 -- it's not really a matter of "take old and new" at all, it's a matter of (1) accept a delta and (2) VALIDATE IT. (1) is relatively easy, although it does demand some API fixing, but (2) demands state access to an environ so we can actually do the validation -- it requires essentially the same mechanism as the add-machine prechecker work that axw investigated last year.

[Canonical Juju QA Bot (juju-qa-bot)]

This bug has not been updated in 5 years, so we're marking it Expired. If you believe this is incorrect, please update the status.