Charm icon template doesn't scale correctly

[Martin Taylor]

The Charms icon template at https://juju.ubuntu.com/docs/media/icon.svg contains these attributes in the opening <svg> element:

  width="96"
  height="96"

With these attributes in place, any svg that is created using Inkscape based on this icon template will not scale elastically and will not render at the correct size in the Juju canvas.

These attributes need to be replaced with a viewbox attribute as follows:

  viewBox="0 0 96 96"

With that change, the icon will scale correctly.

[Richard Harding (rharding)]

Thanks, I believe we add the viewbox when we ingest charms and we've started supporting them in bundles in code that's in trunk.

Assigning over to UX to update the template though please let me know if you hit the issue in production.

[Brad Crittenden (bac)]

Note that the changes to charmstore have not yet been released.

[Anthony Dillon (ya-bo-ng)]

Does this icon still need to be edited?

juju.ubuntu.com has been depreciated.

Thanks,
Ant.

[Martin Taylor (martin-taylor)]

If juju.ubuntu.com has been deprecated, where are you now hosting the svg template for Juju charm icons?

Martin

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Anthony Dillon
Sent: 28 April 2015 21:16
To: Martin Taylor
Subject: [Bug 1421280] Re: Charm icon template doesn't scale correctly

Does this icon still need to be edited?

juju.ubuntu.com has been depreciated.

Thanks,
Ant.

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1421280

Title:
  Charm icon template doesn't scale correctly

Status in Juju Graphical Interface:
  Triaged

Bug description:
  The Charms icon template at
  https://juju.ubuntu.com/docs/media/icon.svg contains these attributes
  in the opening <svg> element:

    width="96"
    height="96"

  With these attributes in place, any svg that is created using Inkscape
  based on this icon template will not scale elastically and will not
  render at the correct size in the Juju canvas.

  These attributes need to be replaced with a viewbox attribute as
  follows:

    viewBox="0 0 96 96"

  With that change, the icon will scale correctly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/juju-gui/+bug/1421280/+subscriptions

[Martin Taylor (martin-taylor)]

I'm assuming that the current icon template is here:
https://jujucharms.com/static/img/jujudocs/master/icon.svg

This version still suffers from the same bug.

Martin

-----Original Message-----
From: Martin Taylor
Sent: 29 April 2015 08:24
To: 'Bug 1421280'
Subject: RE: [Bug 1421280] Re: Charm icon template doesn't scale correctly

If juju.ubuntu.com has been deprecated, where are you now hosting the svg template for Juju charm icons?

Martin

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Anthony Dillon
Sent: 28 April 2015 21:16
To: Martin Taylor
Subject: [Bug 1421280] Re: Charm icon template doesn't scale correctly

Does this icon still need to be edited?

juju.ubuntu.com has been depreciated.

Thanks,
Ant.

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1421280

Title:
  Charm icon template doesn't scale correctly

Status in Juju Graphical Interface:
  Triaged

Bug description:
  The Charms icon template at
  https://juju.ubuntu.com/docs/media/icon.svg contains these attributes
  in the opening <svg> element:

    width="96"
    height="96"

  With these attributes in place, any svg that is created using Inkscape
  based on this icon template will not scale elastically and will not
  render at the correct size in the Juju canvas.

  These attributes need to be replaced with a viewbox attribute as
  follows:

    viewBox="0 0 96 96"

  With that change, the icon will scale correctly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/juju-gui/+bug/1421280/+subscriptions

[Anthony Dillon (ya-bo-ng)]

Thank you very much Martin.

I will update each SVG.