Bundles with revision-less charm URLs should deploy
Bug #1277696 reported by
Brad Crittenden
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-gui |
Fix Released
|
High
|
Brad Crittenden | ||
Bug Description
If a bundle has charms with URLs that do not have revisions, an error will be reported by the juju-core API call to deploy.
The juju-deployer does not have this restriction since it uses the juju-core CLI to deploy.
The preferred solution is to make the extended version of the juju-deployer that guiserver uses call the charm store to get a concrete charm URL if a revision-less one is encountered[1] and pass the concrete URL to the juju-core API call.
It is desired that this functionality be pushed upstream to juju-deployer so that it benefits from the faster deploys via the API.
[1] https:/
Related branches
lp:~bac/juju-deployer/bug-1277696
- juju-deployers: Pending requested
-
Diff: 375 lines (+160/-37)9 files modified.lbox (+1/-0)
.lbox.check (+4/-0)
deployer/charm.py (+5/-17)
deployer/env/gui.py (+10/-1)
deployer/guiserver.py (+4/-12)
deployer/tests/test_constraints.py (+1/-1)
deployer/tests/test_guienv.py (+18/-2)
deployer/tests/test_utils.py (+71/-2)
deployer/utils.py (+46/-2)
| Changed in juju-gui: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| Changed in juju-gui: | |
| assignee: | nobody → Brad Crittenden (bac) |
| Changed in juju-gui: | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
