Cannot open Browse if sidebar is minimized
Bug #1214058 reported by
Jeff Pihach
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-gui |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
To reproduce:
on comingsoon
minimize sidebar as soon as the page loads
click 'Browse'
Related branches
lp:~jcsackett/juju-gui/browse-will-not-open-from-minimized
- Juju GUI Hackers: Pending requested
-
Diff: 188 lines (+139/-2)2 files modifiedapp/subapps/browser/views/minimized.js (+73/-2)
test/test_browser_app.js (+66/-0)
| Changed in juju-gui: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → j.c.sackett (jcsackett) |
Revision history for this message
| Richard Harding (rharding) wrote | #1 |
| Changed in juju-gui: | |
| status: | Triaged → Fix Committed |
| Changed in juju-gui: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is caused because of the cleanup work in https:/
Before, the left over view was still bound to the viewmode controls which handle this change. Now that they're cleaned up and removed, the minimized view must take over handling of the viewmode controls while it's alive. We also need to make sure that it's properly destroyed once the view changes over.