Nodes within a g.service node in env view are duplicated on creation
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-gui |
Fix Released
|
High
|
Madison Scott-Clary |
Bug Description
When deploying a service, before receiving the delta on success, a service block is created in the environment view and populated with initial data (that is, the SVG image node for the block, the text for the name, and so on). When the service is successfully deployed, the same action is repeated, and the g (grouping) element is populated with duplicate SVG tags, rather than the previous tags being modified or replaced.
This isn't visible with regular services, but on deploying a subordinate service, the block is initially created with a non-subordinate SVG element (as the UI doesn't know that the service is a subordinate until the delta arrives), leading to both a regular service block and a subordinate service block appearing in the same group element, visible as a portion of the regular block visible on the top of the subordinate block (see attached). Visibility aside, this clutters the DOM and has the potential to slow the UI.
Fixed by a refresh, since that will recreate the env view.
Here's a sample of the created SVG: http://
Related branches
- Juju GUI Hackers: Pending requested
-
Diff: 537 lines (+265/-198)3 files modifiedapp/views/topology/mega.js (+218/-196)
test/test_environment_view.js (+47/-1)
undocumented (+0/-1)
Changed in juju-gui: | |
assignee: | nobody → Matthew Scott (makyo) |
milestone: | none → 0.1.3+build.302 |
status: | New → In Progress |
Changed in juju-gui: | |
status: | In Progress → Fix Released |