deployer doesn't support juju 2.0 network-spaces feature

[Junaid Ali]

juju-deployer ignores extra-bindings section and expects os-*-network configuration parameters when multiple vips are specified for certain charms.

I'm using juju-deployer from Tim Van Steenburgh's PPA to test it with juju 2.0

[Xav Paice (xavpaice)]

I assume you mean the bindings referenced in https://jujucharms.com/docs/2.1/charms-bundles#binding-endpoints-of-applications-within-a-bundle - i.e. the --bind cli option for 'juju deploy'

The Service class only includes a subset of the properties that is supported by 'juju deploy'.

Seems simple enough to add it, working on a patch now.

[Xav Paice (xavpaice)]

Currently, with a system using Maas 2.1.4, Juju 2.1.1, and two networks, I find LXDs get placed on the 'wrong' network without using spaces. This means that I cannot use juju-deployer (therefore also mojo) for that environment as a result of the lack of support.

I've uploaded a patch but am having some difficulty getting tests to work properly - some assistance with that would be appreciated.

http://pastebin.ubuntu.com/24186741/ is what I'm seeing - yeah, I know I don't have Python 3.4 :)

[James Hebden (ec0)]

I managed to get the tests working in a Xenial LXD, and have compared the test results on the master branch and your proposed branch Xav - and the results are the same. For the record, the Python 3.4 tests are also the same, and the same as the Python 2.7 and 3.5 results on both branches.

Xav's branch: http://pastebin.ubuntu.com/24220098/
Master: http://pastebin.ubuntu.com/24220098

diff shows no difference between output, so these changes have not caused any additional tests to fail that were not already failing in master.

[Drew Freiberger (afreiberger)]

Testing this juju-deployer patch and getting the following:

if we extend args list as ["--bind", "'private'"], it gives
  error: --bind must be in the form '[<default-space>] [<endpoint-name>=<space> ...]'. Space name invalid.
if we extend args list as ["--bind 'private'"], it gives
  error: flag provided but not defined: --bind 'private'

$ juju list-spaces
Space Subnets
private 10.X.0.0/21
public 192.X.0.0/24

[Junaid Ali (junaidali)]

Thanks @Xav. I wasn't following this but looks great to see the support landed in.

@Drew, have you tried the form suggested e.g
 ["--bind", '["default"] ["admin"="private"]']

sorry if I'm wrong.

[Junaid Ali (junaidali)]

looks great that the support landed in**