False ERROR output

Bug #1391889 reported by Brad Crittenden
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
juju-deployer
Fix Released
Low
Edward Hope-Morley

Bug Description

juju-deployer generates a lot of errors like:

2014-11-12 13:19:15 [DEBUG] deployer.import: Getting charms...
2014-11-12 13:19:15 [ERROR] deployer.charm: Service: squid-reverseproxy has neither charm url or branch specified

It then goes on to successfully deploy.

Seems to be crying wolf here. ERROR implies to me that the deploy is going to fail. Perhaps INFO or WARN would be more appropriate.

Related branches

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

agreed

Changed in juju-deployer:
status: New → Triaged
importance: Undecided → Low
Changed in juju-deployer:
assignee: nobody → Edward Hope-Morley (hopem)
status: Triaged → In Progress
Revision history for this message
Edward Hope-Morley (hopem) wrote :

The following bundle:

$ cat bundle.yaml
myenv:
  services:
    ubuntu:
      charm: ubuntu
      local: trusty/ubuntu

Produces the following output:

$ juju-deployer -c bundle.yaml -d myenv
2015-06-30 22:42:00 [DEBUG] deployer.cli: Using runtime GoEnvironment on lxc
2015-06-30 22:42:00 [INFO] deployer.cli: Starting deployment of myenv
2015-06-30 22:42:00 [DEBUG] deployer.import: Getting charms...
2015-06-30 22:42:00 [ERROR] deployer.charm: Service: ubuntu has neither charm url or branch specified
2015-06-30 22:42:00 [DEBUG] deployer.deploy: Resolving configuration
2015-06-30 22:42:00 [DEBUG] deployer.env: Connecting to environment...
2015-06-30 22:42:01 [DEBUG] deployer.env: Connected to environment
2015-06-30 22:42:01 [INFO] deployer.import: Deploying services...
2015-06-30 22:42:01 [DEBUG] deployer.import: <deployer.env.go.GoEnvironment object at 0x7fa7390d0b90>
2015-06-30 22:42:01 [ERROR] deployer.charm: Service: ubuntu has neither charm url or branch specified
2015-06-30 22:42:01 [INFO] deployer.import: Deploying service ubuntu using local:trusty/ubuntu
2015-06-30 22:42:13 [DEBUG] deployer.import: Adding units...
2015-06-30 22:42:13 [DEBUG] deployer.import: Service 'ubuntu' does not need any more units added.
2015-06-30 22:42:13 [DEBUG] deployer.import: Waiting for units before adding relations
2015-06-30 22:42:14 [DEBUG] deployer.env: Delta machine: 1 change:pending
...

Note the erroneous "[ERROR] deployer.charm: Service: ubuntu has neither charm url or branch specified" which in fact gets printed for every single service deployed in this way (including subordinates) so when i have 30 odd services being de[ployed my screen fills up with ERRORs. Using locally cached charms in this way is totally legitimate so there is no need for an error or warning (or any log for that matter).

Changed in juju-deployer:
milestone: none → 0.5.2
status: In Progress → Fix Committed
Changed in juju-deployer:
status: Fix Committed → Fix Released
Revision history for this message
Edward Hope-Morley (hopem) wrote :

@tvansteenburgh i don't see 0.5.2 in ppa:juju/stable or ppa:juju/proposed. Am i looking in the wrong place or has this not been released yet?

Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

@hopem, sorry, just saw your last message. It's in pypi but not the ppa. Typically @frankban does the ppa releases - feel free to ping him about getting a new one.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.