Incompatible cookie format change

[Aaron Bentley]

As ~jog writes:
  Starting with revision build 3243 (http://reports.vapour.ws/releases/3243) tests are failing due to a change in cookie format. There
  is a per user cookie file ($HOME/.go-cookies), which means Juju clients of different versions will collide.

Issue
http://reports.vapour.ws/releases/issue/56329c09749a5627f93a5302

[James Tunnicliffe (dooferlad)]

Deleting the cookie file (which was empty for me) worked around the problem.

[Aaron Bentley (abentley)]

@dooferlad, it's good to note workarounds, but we need this bug to be fixed. It's breaking testing, it will break users, and the workaround we tried also breaks testing.

[Casey Marshall (cmars)]

I think we should delete the cookies out of the CI workspace and close this bug. There is no guarantee of compatibility until we cut a release. There is no compatibility issue with prior releases of Juju (< 1.26), because this is a new feature.

We should add a CI test for cookie compatibility once 1.26 branches, but that is a separate concern to this specific bug I think.

[Aaron Bentley (abentley)]

Trunk should always be releaseable. Trunk should not break CI. Valid bug.

[Casey Marshall (cmars)]

Re-opening until I can confirm this wouldn't be a problem for 1.25.0 -> 1.26.x, just realized that went out.

[Casey Marshall (cmars)]

Releaseable yes. Fully compatible across each commit to master, no. We make changes to API, state models, all kind of things in master until we branch for a release.

We do need to ensure compatibility across releases.

[Aaron Bentley (abentley)]

BTW, John George did try to work around it, but those workarounds themselves broke CI.

[Aaron Bentley (abentley)]

Please keep it open until you convince QA that it is not a critical regression and until it does not break CI.

[Casey Marshall (cmars)]

Ah, this will indeed be an issue for 1.25 -> 1.26. We'll need to add support for migrating the cookie jar. Thanks.

[Casey Marshall (cmars)]

https://github.com/juju/persistent-cookiejar/issues/8

[Casey Marshall (cmars)]

Per discussion with mgz, I'm going to follow this up with an update targeting 1.25.1, that will address 1.26 -> 1.25 compatibility.

[Casey Marshall (cmars)]

Review for 1.25 fix: http://reviews.vapour.ws/r/3041/

[Canonical Juju QA Bot (juju-qa-bot)]

Juju-CI verified that this issue is Fix Released in juju-core master:
    http://reports.vapour.ws/releases/3257