grant-revoke: reenabled users missing from list-users

[Curtis Hovey]

As seen at
   http://reports.vapour.ws/releases/issue/57a22149749a564903b6bcda

The user-list
JujuAssertionError: [
{u'user-name': u'admin', u'display-name': u'admin'},
{u'user-name': u'readuser', u'display-name': u''}]

does not match the list of users in user_list_admin_read_write
[{u'user-name': u'admin', u'display-name': u'admin'},
 {u'user-name': u'readuser', u'display-name': u'',
 {u'user-name"' u'writeuser', u'display-name': u''}}]

after enabling a previously disabled the user named 'writeuser'

[Curtis Hovey (sinzui)]

This test case doesn't match my expectations. If I disable a user don't expect the user to still be in the list.

[Curtis Hovey (sinzui)]

This test failures co-inside with a change to the test, not juju. I think the test is wrong.

[Richard Harding (rharding)]

+1 I would expect the user to be there but that there was new metadata indicating a deactivated status of some sort.

[Curtis Hovey (sinzui)]

The rules for disabled users were changed/fixed in https://github.com/juju/juju/commit/4d37bf304cb18f650c944e0f2a6f5390f25273ff

[Curtis Hovey (sinzui)]

The test error is reporting that a users can be disabled. The user will be removed from the list. But when the user is enabled, the user is not restored to the list. the user is missing.

[Andrew Wilkins (axwalk)]

This is fixed by https://github.com/juju/juju/pull/5877.

[Reed O'Brien (reedobrien)]

axwalk noted this is fixed in comment 6 -- https://bugs.launchpad.net/juju-core/+bug/1609494/comments/6