Race in github.com/juju/juju/cmd/modelcmd

[Curtis Hovey]

As seen at
    http://reports.vapour.ws/releases/issue/57a0c905749a5613ca4934f2

There are repeated races with a single run of the unit tests involving github.com/juju/juju/cmd/modelcmd

[Curtis Hovey (sinzui)]

WARNING: DATA RACE
Write by goroutine 421:
  bytes.(*Buffer).Write()
      /usr/lib/go-1.6/src/bytes/buffer.go:133 +0x4b
  fmt.Fprintln()
      /usr/lib/go-1.6/src/fmt/print.go:255 +0xc5
  github.com/juju/loggo.(*simpleWriter).Write()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/loggo/writer.go:65 +0x198
  github.com/juju/loggo.(*Context).write()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/loggo/context.go:119 +0xf3
  github.com/juju/loggo.(*module).write()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/loggo/module.go:60 +0x78
  github.com/juju/loggo.Logger.LogCallf()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/loggo/logger.go:109 +0x29c
  github.com/juju/loggo.Logger.Logf()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/loggo/logger.go:65 +0x71
  github.com/juju/loggo.Logger.Infof()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/loggo/logger.go:129 +0x68
  github.com/juju/juju/api.connectWebsocket()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/api/apiclient.go:297 +0x792
  github.com/juju/juju/api.open()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/api/apiclient.go:171 +0x144
  github.com/juju/juju/api.Open()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/api/apiclient.go:156 +0xa5
  github.com/juju/juju/cmd/modelcmd.(*JujuCommandBase).apiOpen()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/modelcmd/base.go:247 +0x197
  github.com/juju/juju/cmd/modelcmd.(*JujuCommandBase).(github.com/juju/juju/cmd/modelcmd.apiOpen)-fm()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/modelcmd/base.go:161 +0x9a
  github.com/juju/juju/cmd/modelcmd.newAPIConnectionParams.func1()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/modelcmd/base.go:302 +0xc9
  github.com/juju/juju/juju.NewAPIConnection()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/juju/api.go:75 +0x316
  github.com/juju/juju/cmd/modelcmd.(*JujuCommandBase).NewAPIRoot()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/modelcmd/base.go:114 +0x3f8
  github.com/juju/juju/cmd/modelcmd.(*JujuCommandBase).NewAPIRoot-fm()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/modelcmd/controller.go:155 +0x9b
  github.com/juju/juju/cmd/modelcmd.OpenFunc.Open()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/modelcmd/apiopener.go:27 +0x9f
  github.com/juju/juju/cmd/modelcmd.(*ControllerCommandBase).NewAPIRoot()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/modelcmd/controller.go:157 +0x3b6
  github.com/juju/juju/cmd/juju/controller.(*destroyCommandBase).getControllerAPI()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/juju/controller/destroy.go:312 +0xdc
  github.com/juju/juju/cmd/juju/controller.(*destroyCommand).Run()
      /home/ubuntu/juju-core_2.0-beta14/src/github.com/juju/juju/cmd/juju/controller/destroy.go:125 +0x2d4
  github.com/juju/juju/cmd/modelcmd.(*sysCommandWrapper).Run()
      <autogenerated>:109 +0x84
  github.com/juju/juju/cmd/modelcmd.(*baseCommandWrapper).Run()
    ...

[Curtis Hovey (sinzui)]

the first commit to see this is
    https://github.com/juju/juju/commit/df65efda1f36866589e52415d5464915709aa511
    https://github.com/juju/juju/commit/736184841c318dcbf596abc939286b415a1d6170

Two other recent suspects are
    https://github.com/juju/juju/commit/aed9e6349b71dafc73c4a7f61a808b93a6643b4a
    https://github.com/juju/juju/commit/450ca618a68017aae7ed40008a6e8f893c2fb240