Client side watchers may still be active when they report themselves as dead

[Menno Finlay-Smits]

The client side watchers in api/watchers may still have goroutines running even when they have reported themselves as dead. This is because Done is called on the tomb without waiting for the goroutines started by commonWatcher.

This can be a source of subtle bugs and can make testing more difficult.

A possible solution would be to use catacombs and turn commonWatcher into a worker and each watcher type into workers with some interaction between them. The current approach of embedding commonWatcher into each watcher type and loosely sharing data and a tomb between them is quite messy at best.

[Anastasia (anastasia-macmood)]

As this is a tech-debt item, I am lowering its Importance.

[Canonical Juju QA Bot (juju-qa-bot)]

This bug has not been updated in 5 years, so we're marking it Expired. If you believe this is incorrect, please update the status.