Session already closed in state/presence

[Tim Penhey]

As seen here: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7965/console

panic: Session already closed

goroutine 1868 [running]:
panic(0x9b08e0, 0xc82043fd00)
 /usr/lib/go-1.6/src/runtime/panic.go:464 +0x3e6
gopkg.in/mgo%2ev2.(*Session).cluster(0xc82056fba0, 0xa)
 /home/ubuntu/juju-core_2.0-delta1/src/gopkg.in/mgo.v2/session.go:1549 +0x75
gopkg.in/mgo%2ev2.copySession(0xc82056fba0, 0x1, 0xc82043fcf0)
 /home/ubuntu/juju-core_2.0-delta1/src/gopkg.in/mgo.v2/session.go:519 +0x30
gopkg.in/mgo%2ev2.(*Session).Copy(0xc82056fba0, 0x24)
 /home/ubuntu/juju-core_2.0-delta1/src/gopkg.in/mgo.v2/session.go:1515 +0x3b
github.com/juju/juju/state/presence.(*Watcher).sync(0xc8200c54a0, 0x0, 0x0)
 /home/ubuntu/juju-core_2.0-delta1/src/github.com/juju/juju/state/presence/presence.go:403 +0x209
github.com/juju/juju/state/presence.(*Watcher).loop(0xc8200c54a0, 0x0, 0x0)
 /home/ubuntu/juju-core_2.0-delta1/src/github.com/juju/juju/state/presence/presence.go:279 +0x2b2
github.com/juju/juju/state/presence.NewWatcher.func1(0xc8200c54a0)
 /home/ubuntu/juju-core_2.0-delta1/src/github.com/juju/juju/state/presence/presence.go:146 +0x38
created by github.com/juju/juju/state/presence.NewWatcher
 /home/ubuntu/juju-core_2.0-delta1/src/github.com/juju/juju/state/presence/presence.go:156 +0x574
FAIL github.com/juju/juju/state/presence 5.465s

[Dave Cheney (dave-cheney)]

I cannot repro with the same scenario, trusty and mongo2.4

[Dave Cheney (dave-cheney)]

But it happens regularly in CI, http://juju-ci.vapour.ws:8080/job/github-merge-juju/7972/console

[Anastasia (anastasia-macmood)]

I am seeing it all the time with my branch...

My proposal removes "omitempty" on being and pinger info "_id" in presence.

[Anastasia (anastasia-macmood)]

This is the PR... https://github.com/juju/juju/pull/5515.

I'll look at fixing tests here too.

[Dave Cheney (dave-cheney)]

https://github.com/juju/juju/pull/5543