all: data races in tests are surpressed

[Dave Cheney]

Back in https://github.com/juju/juju/commit/62097950d4677fb8ef6c9c83e3d7555eebf2c653 I disabled the remaining race tests to get the race build passing. I don't remember the logic behind this decision, probably something about getting the race build running so we didn't continue to regress further.

The skipped tests have bugs, but because they are no longer blocking the build, they aren't going to get fixed ... so we have data races, and instability in juju and ignoring the underlying cause.

[Dave Cheney (dave-cheney)]

Blocked on https://bugs.launchpad.net/juju-core/+bug/1519133 and others

[Dave Cheney (dave-cheney)]

Current status
worker/addresser/package_test.go:
15: if testing.RaceEnabled {

environs/bootstrap/package_test.go:
14: if testing.RaceEnabled {

featuretests/package_test.go:
46: if testing.RaceEnabled {

apiserver/client/package_test.go:
15: if testing.RaceEnabled {

worker/leadership/package_test.go:
15: if testing.RaceEnabled {

provider/ec2/package_test.go:
17: if testing.RaceEnabled {

cmd/juju/commands/package_test.go:
23: if gittesting.RaceEnabled {

apiserver/provisioner/provisioner_test.go:
38: if jujutesting.RaceEnabled {

provider/joyent/package_test.go:
15: if testing.RaceEnabled {

apiserver/uniter/package_test.go:
15: if testing.RaceEnabled {

cmd/juju/service/package_test.go:
22: if gittesting.RaceEnabled {

[Dave Cheney (dave-cheney)]

All the skips have been removed from the code and as best I can tell we have no races blocking the build at the moment.