NoContextWithLock fails on windows because of another process

Bug #1580802 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Invalid
High
Unassigned

Bug Description

As seen in
    http://reports.vapour.ws/releases/issue/566f31a4749a567a419881ff

NoContextWithLock fails on windows because of of contention between 2 or more processes

run_test.go:158:
    c.Assert(err, jc.Satisfies, cmd.IsRcPassthroughError)
... obtained *errors.Err = &errors.Err{message:"", cause:(*os.PathError)(0xc0825caf30), previous:(*errors.Err)(0xc0821200f0), file:"github.com/juju/juju/cmd/jujud/run.go", line:108} ("remove c:\\users\\admini~1\\appdata\\local\\temp\\tmpgyyfp2\\gogo\\tmp-juju-test9oigfy\\check-4812758913080376832\\12\\locks/uniter-hook-execution/alive.4680: The process cannot access the file because it is being used by another process.")
... func(T) bool func(error) bool = (func(error) bool)(0x5b37d0)

run_test.go:193:
    c.Assert(err, jc.ErrorIsNil)
... value *errors.errorString = &errors.errorString{s:"timeout"} ("timeout")

Note that this issue is preceded by a warning
2016-05-11 11:05:01 WARNING utils.featureflag flags_windows.go:43 Failed to read juju registry value JUJU_DEV_FEATURE_FLAGS; feature flags not enabled

Revision history for this message
Curtis Hovey (sinzui) wrote :

This retest of master tip after a reboot is playing at this moment. It also shows this error.

description: updated
Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
status: Triaged → In Progress
Revision history for this message
Dave Cheney (dave-cheney) wrote :

This is another case of fslock being rubbish.

Revision history for this message
Dave Cheney (dave-cheney) wrote :
Changed in juju-core:
status: In Progress → Triaged
assignee: Dave Cheney (dave-cheney) → nobody
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 2.0-beta7 → 2.0-beta8
tags: removed: blocker
Nate Finch (natefinch)
Changed in juju-core:
assignee: nobody → Nate Finch (natefinch)
status: Triaged → In Progress
Curtis Hovey (sinzui)
tags: added: blocker
Changed in juju-core:
importance: Critical → High
Curtis Hovey (sinzui)
Changed in juju-core:
importance: High → Critical
Changed in juju-core:
assignee: Nate Finch (natefinch) → nobody
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 2.0-beta8 → 2.0-beta9
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 2.0-beta9 → 2.0-beta10
Revision history for this message
Curtis Hovey (sinzui) wrote :

This issue has not been seen in a week. Either someone fixed the issue indirectly or the the test suite asa while is behaving differently. I am marking this incomplete

Changed in juju-core:
importance: Critical → High
status: In Progress → Incomplete
tags: removed: blocker
Revision history for this message
Anastasia (anastasia-macmood) wrote :

We have also recently changed the locks :)

This may no longer be valid \o/

Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 2.0-beta10 → 2.0-beta11
Revision history for this message
William Reade (fwereade) wrote :

Code in question no longer exists; closing

Changed in juju-core:
status: Incomplete → Invalid
affects: juju-core → juju
Changed in juju:
milestone: 2.0-beta11 → none
milestone: none → 2.0-beta11
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.