Race in github.com/juju/juju/worker/instancepoller/aggregate_test.go

[Curtis Hovey]

As seen in
    http://reports.vapour.ws/releases/issue/5731e350749a566a75929775
There is an intermittent race involving github.com/juju/juju/worker/instancepoller.(*aggregateSuite).TestBatching().

Bug 1579051 might be related because is it seen in the same revision failures.

[Reed O'Brien (reedobrien)]

PR: https://github.com/juju/juju/pull/5371
RB: http://reviews.vapour.ws/r/4800/

[Curtis Hovey (sinzui)]

Sorry. The fix is incomplete. As seen in
    http://reports.vapour.ws/releases/issue/5731e350749a566a75929775

http://reports.vapour.ws/releases/3963 failed because both runs of run-unit-tests-race saw this race:
    http://reports.vapour.ws/releases/3963/job/run-unit-tests-race/attempt/1445
    http://reports.vapour.ws/releases/3963/job/run-unit-tests-race/attempt/1444

[Reed O'Brien (reedobrien)]

Boo! I was running only the worker/instancepoller package when I verified. Will do the full suite again to reproduce. Not sure why CI gets it so reliably when I didn't get it in ~100 runs with the race flag.

I'll try on a slower machine, too.