Juju binaries should be stripped

Bug #1564662 reported by Martin Packman
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Unassigned
juju-core (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned

Bug Description

Previously the juju team has been asked to strip the go binaries in the distro packaging. Per bug 1265970 that was not possible as with go 1.2 it introduced bugs such as bug 1200255.

With go 1.6 in xenial, it may now be safe to strip the juju binaries, but this needs testing on all architectures, including exercising the reflect code.

See irc log for more background:

<http://irclogs.ubuntu.com/2016/03/31/%23ubuntu-release.html#t20:21>

Revision history for this message
Richard Harding (rharding) wrote :

This will be a target for the Juju team to update and verify that the stripping of the binary is safe and passes all testing. This requires building in some gating based on if the binary is golang vs gccgo.

Changed in juju-core:
status: New → Triaged
importance: Undecided → High
milestone: none → 2.1.0
Curtis Hovey (sinzui)
tags: added: packaging
Revision history for this message
John A Meinel (jameinel) wrote :

I tried stripping my 1.6 based build, and it seems to be working. (Juju does reflection at init() time as part of some of the registries), so it seems safe to do. On the flip side it isn't amazingly better. It seems to be a bit less than 2:1. (73MB down to 40MB.) Almost certainly still worth it, just doesn't compensate for the 1:10 growth of the Juju binary itself over time.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Re: [Bug 1564662] Re: Juju binaries should be stripped

building cmd/juju with go 1.7 tip and then stripping results in a
binary that is "only" 33 MB, so there is some progress being made
there too :-)

On 6 April 2016 at 17:30, John A Meinel <email address hidden> wrote:
> I tried stripping my 1.6 based build, and it seems to be working. (Juju
> does reflection at init() time as part of some of the registries), so it
> seems safe to do. On the flip side it isn't amazingly better. It seems
> to be a bit less than 2:1. (73MB down to 40MB.) Almost certainly still
> worth it, just doesn't compensate for the 1:10 growth of the Juju binary
> itself over time.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1564662
>
> Title:
> Juju binaries should be stripped
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-core/+bug/1564662/+subscriptions

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 2.0~beta12-0ubuntu3.16.10.1

---------------
juju-core (2.0~beta12-0ubuntu3.16.10.1) yakkety; urgency=medium

  * Add skip to current-manual-provider for bug 1605313 and bug 1605050

 -- Nicholas Skaggs <email address hidden> Thu, 21 Jul 2016 15:12:52 -0400

Changed in juju-core (Ubuntu):
status: New → Fix Released
Martin Packman (gz)
Changed in juju-core:
milestone: 2.1.0 → 2.0.0
status: Triaged → Fix Released
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 2.0.0 → 2.0-beta14
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Martin, or anyone else affected,

Accepted juju-core into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/juju-core/2.0~beta12-0ubuntu1.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in juju-core (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 2.0~beta12-0ubuntu1.16.04.1

---------------
juju-core (2.0~beta12-0ubuntu1.16.04.1) xenial-proposed; urgency=medium

  [ Nicholas Skaggs ]
  * New upstream release 2.0-beta12 (LP: #1604137).
  * Update debian/copyright.
  * Add skip to current-manual-provider for bug 1605313 and bug 1605050
  * Fix adt test for manual-provider

  [ Martin Packman ]
  * Allow stripping of go binaries (LP: #1564662).
  * Mark juju-2.0 as conflicting and replacing old ppas (LP: #1600257).
  * Adjust where bash completion script is installed (LP: #1588403).

 -- Nicholas Skaggs <email address hidden> Mon, 18 Jul 2016 14:00:19 -0400

Changed in juju-core (Ubuntu Xenial):
status: Fix Committed → Fix Released
affects: juju-core → juju
Changed in juju:
milestone: 2.0-beta14 → none
milestone: none → 2.0-beta14
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.