private-address returns name, not ip
Bug #1557769 reported by
Stuart Bishop
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Juju |
Fix Released
|
High
|
Unassigned | ||
Charm Helpers |
In Progress
|
Critical
|
Unassigned | ||
PostgreSQL Charm |
Fix Released
|
Critical
|
Unassigned | ||
Telegraf Charm |
Fix Released
|
High
|
Wouter van Bommel | ||
juju-core |
Invalid
|
High
|
Unassigned | ||
1.25 |
Won't Fix
|
High
|
Unassigned | ||
cassandra (Juju Charms Collection) |
Fix Released
|
Critical
|
Unassigned |
Bug Description
Under Juju 1.25.4:
$ juju run --unit=dse/0 'unit-get private-address'
sudice.internal
Previously this returned an IP address.
This breaks charm-helpers, where hookenv.
This breaks at least two charms using hookenv.
Related branches
lp:~stub/charm-helpers/bug-1557769-ensure-ip-address
Ready for review
for merging
into
lp:charm-helpers
- charmers: Pending requested
-
Diff: 131 lines (+56/-9)3 files modifiedMakefile (+2/-2)
charmhelpers/core/hookenv.py (+19/-2)
tests/core/test_hookenv.py (+35/-5)
Changed in charm-helpers: | |
status: | New → In Progress |
importance: | Undecided → Critical |
assignee: | nobody → Stuart Bishop (stub) |
Changed in cassandra (Juju Charms Collection): | |
status: | New → In Progress |
importance: | Undecided → Critical |
assignee: | nobody → Stuart Bishop (stub) |
Changed in juju-core: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → 1.25.5 |
Changed in juju-core: | |
milestone: | 1.25.5 → 1.25.6 |
Changed in cassandra (Juju Charms Collection): | |
status: | In Progress → Fix Released |
Changed in juju-core: | |
milestone: | 1.25.6 → 1.25.7 |
Changed in juju-core: | |
status: | Triaged → Invalid |
milestone: | 1.25.7 → none |
Changed in juju: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → 2.0.0 |
summary: |
- private-address returns name, not ip, under 1.25.4 + private-address returns name, not ip |
Changed in postgresql-charm: | |
assignee: | nobody → Stuart Bishop (stub) |
status: | Triaged → In Progress |
Changed in postgresql-charm: | |
status: | In Progress → Fix Released |
Changed in juju: | |
status: | New → Triaged |
tags: | added: manual-provider network |
Changed in charm-telegraf: | |
assignee: | nobody → Wouter van Bommel (woutervb) |
status: | Triaged → In Progress |
Changed in charm-telegraf: | |
status: | In Progress → Fix Released |
Changed in charm-helpers: | |
assignee: | Stuart Bishop (stub) → nobody |
Changed in postgresql-charm: | |
assignee: | Stuart Bishop (stub) → nobody |
Changed in cassandra (Juju Charms Collection): | |
assignee: | Stuart Bishop (stub) → nobody |
To post a comment you must log in.
Charms will retrieve this value from relations (relation-get private-address) and may fail when they are handed a name rather than an IP address (arbitrary depending on provider). This can't be worked around in charm helpers