worker/rsyslog: data races

[Dave Cheney]

WARNING: DATA RACE
Read by goroutine 30:
  github.com/juju/juju/worker/rsyslog_test.(*RsyslogSuite).TestModeForwarding()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/rsyslog/rsyslog_common_test.go:108 +0xd7b
  runtime.call16()
      /usr/lib/go/src/pkg/runtime/asm_amd64.s:338 +0x31
  reflect.Value.Call()
      /usr/lib/go/src/pkg/reflect/value.go:345 +0xaa
  gopkg.in/check%2ev1.func·003()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:772 +0x504
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:666 +0xf3

Previous write by goroutine 129:
  github.com/juju/juju/worker/rsyslog.(*RsyslogConfigHandler).replaceRemoteLogger()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/rsyslog/worker.go:246 +0xbce
  github.com/juju/juju/worker/rsyslog.(*RsyslogConfigHandler).Handle()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/rsyslog/worker.go:271 +0x34d
  github.com/juju/juju/worker.(*notifyWorker).loop()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/notifyworker.go:103 +0x353
  github.com/juju/juju/worker.func·003()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/notifyworker.go:56 +0x81

Goroutine 30 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:667 +0x529
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:804 +0x168
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:809 +0x3e
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:615 +0x44a
  gopkg.in/check%2ev1.Run()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/run.go:92 +0x56
  gopkg.in/check%2ev1.RunAll()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/run.go:84 +0x111
  gopkg.in/check%2ev1.TestingT()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/run.go:72 +0x4d6
  github.com/juju/testing.MgoTestPackage()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/testing/mgo.go:354 +0x156
  github.com/juju/juju/testing.MgoTestPackage()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/testing/mgo.go:15 +0x52
  github.com/juju/juju/worker/rsyslog_test.TestPackage()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/rsyslog/rsyslog_common_test.go:29 +0x34
  testing.tRunner()
      /usr/lib/go/src/pkg/testing/testing.go:391 +0x10f

Goroutine 129 (running) created at:
  github.com/juju/juju/worker.NewNotifyWorker()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/notifyworker.go:57 +0x117
  github.com/juju/juju/worker/rsyslog.newRsyslogConfigWorker()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/rsyslog/worker.go:106 +0x32c
  github.com/juju/juju/worker/rsyslog_test.(*RsyslogSuite).TestModeForwarding()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/rsyslog/rsyslog_common_test.go:96 +0x536
  runtime.call16()
      /usr/lib/go/src/pkg/runtime/asm_amd64.s:338 +0x31
  reflect.Value.Call()
      /usr/lib/go/src/pkg/reflect/value.go:345 +0xaa
  gopkg.in/check%2ev1.func·003()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:772 +0x504
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:666 +0xf3
==================
OK: 9 passed
PASS
Found 1 data race(s)
FAIL github.com/juju/juju/worker/rsyslog 76.298s

[Dave Cheney (dave-cheney)]

duplicate

[Anastasia (anastasia-macmood)]

This area has seen a lot of re-work since this report was originally created. We have not seen any problems in the area recently. Marking this as Fixed Released.