juju upgrade --upload-tools tries to upload tools agents that are not permitted by the state server

[Aaron Bentley]

# Juju client is 1.24.7
$ juju version
1.24.7-wily-amd64

# Juju state server is 1.20.14
$ juju status -e peril
environment: peril
machines:
  "0":
    agent-state: started
    agent-version: 1.20.14
    dns-name: ec2-54-173-237-220.compute-1.amazonaws.com
    instance-id: i-3ac3e285
    instance-state: running
    series: trusty
    hardware: arch=amd64 cpu-cores=1 cpu-power=100 mem=1740M root-disk=8192M
    state-server-member-status: has-vote
services: {}

# upgrade-juju --upload-tools fails
$ juju upgrade-juju -e peril --upload-tools --version 1.24.7
ERROR tools upload failed: 400 ({"Tools":null,"DisableSSLHostnameVerification":false,"Error":{"Message":"cannot get environment config: invalid series \"wily\"","Code":""}})

There is a similar bug for sync-tools, bug #1510688; ideally they would be fixed at the same time.

[Anastasia (anastasia-macmood)]

Both upload-tools and the logic around agent validity has been changed on master.

Please re-test as the issue may have been fixed.

[Aaron Bentley (abentley)]

AIUI, upgrade-juju is not yet supported in 2.x. Is it even possible to test?

[Anastasia (anastasia-macmood)]

@Aaron

Good point, I'll add it to 2.1.0 backlog as we are more likely to have some form of upgrade there.

[Anastasia (anastasia-macmood)]

Marking as "Won't Fix" for Juju 1.x as not a critical bug.
Re-targeting for Juju 2.x.

@Aaron,
Please re-word using Juju 2.x terminology.

[Anastasia (anastasia-macmood)]

@Aaron,

Could you please re-test? functional test may be of great benefit here, especially now that we are several Juju 2.x...

[Aaron Bentley (abentley)]

The specific case I've observed was with juju 1.20 as the server. Since Juju can't upgrade from 1.x at the moment, I can't test that. I understand there are plans to support upgrading juju from 1.x, but I don't think upgrading from 1.20 is an important case.

[Anastasia (anastasia-macmood)]

@Aaron,

Since this is only applicable to upgrades from Juju 1.x to Juju 2.x, I am putting it against 2.2 in order to keep track of it when we get to this upgrade story.

Thank you for clarification!

[Anastasia (anastasia-macmood)]

As upgrade from Juju 1.x to 2.x will be done by external tool, this specific case will no longer be applicable.
Marking as Invalid.