Juju doesn't support is own version of 1.25.0

[Curtis Hovey]

My branch to change the Juju version to 1.25.0 is failing
    https://github.com/juju/juju/pull/3576

like this
FAIL: state_test.go:3698: StateSuite.TestSetEnvironAgentVersionOnOtherEnviron

SetUpTest
[LOG] 0:00.003 INFO juju.state opening state, mongo addresses: ["localhost:38319"]; entity <nil>
[LOG] 0:00.003 DEBUG juju.state dialing mongo
[LOG] 0:00.004 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:38319"
[LOG] 0:00.005 DEBUG juju.state connection established
[LOG] 0:00.005 DEBUG juju.state mongodb login successful
[LOG] 0:00.036 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:38319"
[LOG] 0:00.036 INFO juju.state initializing state server environment 324952e2-bc69-469f-8957-aa87c8041886
[LOG] 0:00.054 INFO juju.state running state anonymously; using unique client id
[LOG] 0:00.054 INFO juju.state creating lease client as anon-8626d991-5b4f-40ea-87e0-1dd0938ba7d8
[LOG] 0:00.055 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:38319"
[LOG] 0:00.058 INFO juju.state starting leadership manager
[LOG] 0:00.058 INFO juju.state creating cloud image metadata storage
[LOG] 0:00.058 INFO juju.state starting presence watcher
SetUpTest done
[LOG] 0:00.061 INFO juju.state opening state, mongo addresses: ["localhost:38319"]; entity <nil>
[LOG] 0:00.061 DEBUG juju.state dialing mongo
[LOG] 0:00.062 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:38319"
[LOG] 0:00.063 DEBUG juju.state connection established
[LOG] 0:00.063 DEBUG juju.state mongodb login successful
[LOG] 0:00.072 INFO juju.state running state anonymously; using unique client id
[LOG] 0:00.072 INFO juju.state creating lease client as anon-aa82ef7b-5518-4d99-86f4-92431ab928e0
[LOG] 0:00.073 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:38319"
[LOG] 0:00.074 INFO juju.mongo dialled mongo successfully on address "127.0.0.1:38319"
[LOG] 0:00.077 INFO juju.state starting leadership manager
[LOG] 0:00.077 INFO juju.state creating cloud image metadata storage
[LOG] 0:00.077 INFO juju.state starting presence watcher
state_test.go:3710:
    assertAgentVersion(c, otherSt, lower.Number.String())
state_test.go:3660:
    c.Assert(err, jc.ErrorIsNil)
... value *errors.errorString = &errors.errorString{s:"invalid agent version in environment configuration: \"1.25.-1\""} ("invalid agent version in environment configuration: \"1.25.-1\"")

[LOG] 0:00.147 DEBUG juju.state closed state without error
[LOG] 0:00.154 DEBUG juju.state closed state without error
[LOG] 0:00.157 INFO juju.testing reset successfully reset admin password
2015-10-22 17:36:02 DEBUG juju.state open.go:306 closed state without error
2015-10-22 17:36:02 INFO juju.testing mgo.go:514 reset successfully reset admin password
OOPS: 1212 passed, 1 FAILED
--- FAIL: TestPackage (344.64 seconds)

Also these tests failed 3 times in a row, but I don't see the version being a factor in out out put
   FAIL: status_test.go:3233: StatusSuite.TestStatusV2
   FAIL: status_test.go:3238: StatusSuite.TestStatusWithFormatTabular

See http://juju-ci.vapour.ws:8080/job/github-merge-juju/5192/console

[Curtis Hovey (sinzui)]

The branch that provides the fix should merge my branch, or just update the two version files to 1.25.0 so that we can test the fix with proper version.

[Cheryl Jennings (cherylj)]

The status test failures were already fixed in master as part of this PR: https://github.com/juju/juju/pull/3553

The test failure in state is still present.

[Cheryl Jennings (cherylj)]

Review request for master: http://reviews.vapour.ws/r/2978/

[Curtis Hovey (sinzui)]

We cannot merge https://github.com/juju/juju/pull/3580 to set Juju's version to 1.25.1 because
    FAIL: status_test.go:3233: StatusSuite.TestStatusV2
   FAIL: status_test.go:3238: StatusSuite.TestStatusWithFormatTabular

When 1.25.0 is released, CI will not be able to test any 1.25 commits if the version will impersonate/corrupt a real version.

[Cheryl Jennings (cherylj)]

Argh. Fixing now. I'm just going to use the change that menn0 introduced into master.

[Cheryl Jennings (cherylj)]

I keep running into test timeout issues when trying to test my changes, so it's taking a bit longer than expected.

[Cheryl Jennings (cherylj)]

Updated review request: http://reviews.vapour.ws/r/2981/

[Cheryl Jennings (cherylj)]

I tested this recent PR by modifying the version to be 1.25.0, 1.25.1, 1.25-beta2, and 1.25.11