juju plugins which exit > 0 report a subprocess ERROR

[Marco Ceppi]

When running a plugin via `juju <plugin>` if the plugin exits with a code greater than 0 juju prints

ERROR subprocess encountered error code #

where # is the error code. This creates a confused user experience. To reproduce:

$ cd /tmp
$ sudo apt-get install charm-tools
$ juju charm create -t bash foo
$ juju charm proof foo
[ Error is produced ]
$ charm proof foo
[ Error line isn't included]

---

marco@galago:/tmp⟫ charm proof foo
I: No icon.svg file.
W: no copyright file
W: no README file

marco@galago:/tmp⟫ juju charm proof foo
I: No icon.svg file.
W: no copyright file
W: no README file
ERROR subprocess encountered error code 100

[Casey Marshall (cmars)]

http://reviews.vapour.ws/r/2833/

[Cheryl Jennings (cherylj)]

This was fixed in 1.25.0, but the bug was never moved to Fix Committed.