statusHistoryTestSuite teardown fails on windows

[Martin Packman]

The new statusHistoryTestSuite does not tear down cleanly on windows:

<http://reports.vapour.ws/releases/issue/55f0423f749a56758410bb5a>

FAIL: api_test.go:1: statusHistoryTestSuite.TearDownTest

.../github.com/juju/juju/testing/base_windows.go:59:
    c.Assert(err, jc.ErrorIsNil)
... value syscall.Errno = 0x2 ("The system cannot find the file specified.")

----------------------------------------------------------------------
PANIC: statushistory_test.go:108: statusHistoryTestSuite.TestStatusHistoryAgentOnly

... Panic: Fixture has panicked (see related PANIC)
OOPS: 209 passed, 1 FAILED, 3 MISSED
2015-09-09 04:01:39 ERROR juju.testing mgo.go:274 mongodb has exited without being killed

Added in <https://github.com/juju/juju/pull/3221> and landed as part of the maltese-falcon branch:

<https://github.com/juju/juju/pull/3120>

[Martin Packman (gz)]

This goes for relationsSuite from worker/uniter/relation as well, same issue.

FAIL: mock_test.go:1: relationsSuite.TearDownTest

c:/.../src/github.com/juju/juju/testing/base_windows.go:59:
    c.Assert(err, jc.ErrorIsNil)
... value syscall.Errno = 0x2 ("The system cannot find the file specified.")

----------------------------------------------------------------------
PANIC: relations_test.go:384: relationsSuite.TestHookRelationBroken

request 0, Life
...
request 12, GetPrincipal
... Panic: Fixture has panicked (see related PANIC)

[Tim Penhey (thumper)]

The problem here is that the actual test executables are executed in parallel, and the base os env suite on windows puts the feature flag values into the windows registry.

There is a race between the different test packages running as to who or when the registry key is deleted.

This bug is showing up because two concurrent tests thought they were creating the key, and one deleted it before the other.

The solution here is not to use the registry for this part of the test setup as it is unnecessary.

[Tim Penhey (thumper)]

https://github.com/juju/juju/pull/3271